Repository navigation
Conversation
openwrt
Bot
added
the
not following guidelines
openwrt-ai
reviewed
Oct 18, 2026
| insertTypedSectionOptions(m, s, o, 'dhcp_ntp_server', features); | ||
|
|
||
| // Drift file | ||
| s = m.section(form.NamedSection, 'driftfile', 'driftfile', _('Drift file'), |
Collaborator
There was a problem hiding this comment.
On upgraded systems /etc/config/chrony is kept and won't have a driftfile section. Without addremove a NamedSection then shows only its title and description, with no options and no way to create the section (renderContents in form.js:4268-4295). Should this set s.addremove = true like allow/nts, or does openwrt/packages#30799 add a uci-defaults script that creates the section?
Generated by Claude Code
Contributor
Author
There was a problem hiding this comment.
Patch to chrony allready had uci-defaults file which creates new section when omited.
This commit adds 3 new options: Restore system time, Drift file path and Update interval. These options directly linked with options from uci config. Signed-off-by: Ivan Romanov <drizt72@zoho.eu>
drizt
force-pushed
the
chrony_driftfile
branch
from
October 18, 2026 17:48
83a8950 to
492e77a
Compare
openwrt
Bot
removed
the
not following guidelines
1 task done
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request details
Description
It adds ui options for new section in chrony uci file. See openwrt/packages#30799.
Screenshot or video of changes (if applicable)
Maintainer (preferred)
@systemcrash
Tested on
OpenWrt version: OpenWrt 25.12.5 r33051-f5dae5ece4
LuCI version: LuCI (HEAD detached at 128a781) branch (26.180.75667~128a781)
Web browser(s): Firefox 158.0 (64-bit)
Checklist