docs: installing from a file pins the package, and apk upgrade then says nothing - #187
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing the 3.0.0 upgrade path from the 2.5.1 release artifact.
apk add <file>.apkpins, silentlyIt writes a checksum-pinned entry into
/etc/apk/world:That holds the package to one exact build.
apk upgradethen leaves uapi alone with no error and no mention in its output; the version simply never moves. On a box in that state, with the feed serving 3.0.0 andapk policynaming it:After
apk add uapi, which replaces the pinned entry with a bareuapi:This matters because installing from a file is what we tell people to do for every RC (
docs/release-process.md, the RC release notes) and for any older release now that the feed carries one version. Anyone who dogfoods an RC and later expectsapk upgradeto bring them back to stable stays on the RC indefinitely, with nothing in the output to explain it.grep uapi /etc/apk/worlddistinguishes the two states, and both README anddocs/installation.mdnow say so.A false claim about the feed, in the same file
docs/installation.mdsaid:The feed's index is rebuilt from the latest stable tag on every publish, so the previous release stops resolving as soon as a new one ships.
uapi-2.5.1-r1.apkreturned 404 from the feed within minutes of 3.0.0 publishing, whileuapi-3.0.0-r1.apkreturned 200. A< 3.0.0constraint finds nothing, and an exact pin only works while that build is the current one.The same sentence lived on the website's install page and was corrected there yesterday; this is the copy in the repo. Older releases do stay on the GitHub Releases page permanently, which is the supported way back, and the text now says that instead.
Does this change the wire surface? No, documentation only.
Was it verified against a real device, or only by CI? On a device, both directions: pinned world blocking the upgrade, then a bare world entry letting it through and moving the mount from
/api/v2to/api/v3with the conffile preserved.make lintand 1234 unit tests pass.Was LuCI checked? Not applicable; this is apk behaviour, not a uci surface.
Worth noting what this does not claim: apk's own reasoning was inferred from
/etc/apk/worldand the observed behaviour, not read from apk-tools source, which is not in the SDK feeds. The commands and their effects are measured; the explanation for why apk chooses that is a reading of the evidence.