fix(inference): avoid float32 overflow in StatsNormalizer - #327
Open
ShubhJain09 wants to merge 1 commit into
Open
ShubhJain09 wants to merge 1 commit into
ShubhJain09 wants to merge 1 commit into
Conversation
Signed-off-by: ShubhJain09 <shubhmohta07@gmail.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused implementation resolves the overflow while preserving established dtype behavior with comprehensive regression coverage.
Review effort: Balanced
Findings: None
What changed in this PR
Prevents representable normalization results from overflowing during float32 intermediate calculations.
Changes:
- Performs normalization arithmetic in float64, then restores the expected output dtype.
- Adds overflow regressions and dtype-preservation tests for all normalization modes.
| File | Description |
|---|---|
src/physicalai/inference/preprocessors/stats_normalizer.py |
Uses float64 intermediates across normalization modes. |
tests/unit/inference/preprocessors/test_stats_normalizer.py |
Covers overflow cases and output dtypes. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_normalizeinStatsNormalizernow does the math in float64 and casts the result back to the dtype it produced beforeWhy
2 * (x - q01)overflow float32 to inf even when the normalized value is an ordinary numberValidation
pytest tests/unit packages/*/testspasses andprek run --all-filesis cleanBreaking changes
Related issues