feat(studio-plugin): add RobotZeroCalibration for guided zero-pose calibration - #323
Open
alfieroddan wants to merge 3 commits into
Open
alfieroddan wants to merge 3 commits into
alfieroddan wants to merge 3 commits into
Conversation
alfieroddan
changed the title
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The callback typing cannot represent driver-specific calibration methods, and two import blocks fail Ruff ordering.
Review effort: Balanced
Findings: 1
Open (3)
What changed in this PR
Adds a Studio plugin contract for guided motor zero-pose calibration.
Changes:
- Introduces and exports
RobotZeroCalibration. - Adds optional calibration metadata to robot catalog definitions.
- Documents and tests validation and defaults.
| File | Description |
|---|---|
README.md |
Documents calibration usage. |
__init__.py |
Exports the new contract. |
catalog.py |
Adds catalog calibration metadata. |
zero_calibration.py |
Defines callbacks and validation. |
test_contracts.py |
Tests defaults and validation. |
test_imports.py |
Tests the public export. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: Arms like the reBot B601-RS and Star Arm are calibrated by storing a zero pose on their motors, and plugins have no way to offer that in Studio.
Fix: Add an optional
RobotZeroCalibration(instructions,set_zero, optionalrelease, tolerance) toRobotCatalogDefinitionaszero_calibration.