Align AArch64 ACL integration with oneDNN v3.10.x#313
Open
allnes wants to merge 1 commit into
Open
Conversation
|
Unrelated to PR question: wouldn't it be cheaper to migrate to v3.12 instead of cherry-picking all those necessary changes? |
dc8cd2c to
3f1773b
Compare
Collaborator
Author
@dzarukin Migrating to v3.12 would mean moving the whole oneDNN dependency to v3.12 across all supported architectures, not just taking the AArch64 pieces. That is a much broader integration and validation effort. This PR is intentionally narrower: it removes the obsolete 32-bit ARM path and aligns the AArch64/ACL fork delta with the UXL oneDNN version currently used for this OpenVINO integration. |
3f1773b to
bf097d6
Compare
bf097d6 to
5f79968
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR aligns the OpenVINO oneDNN fork delta for AArch64 ACL support with the v3.10.x integration branch.
The change makes the ACL integration explicitly AArch64-only, moves the ACL-backed CPU primitive code into the AArch64 CPU implementation area, and updates the build and primitive registration paths to use the AArch64-specific ACL configuration.
Technical details
DNNL_USE_ACLbuild option withDNNL_AARCH64_USE_ACL.src/cpu/aclintosrc/cpu/aarch64and updates namespaces, includes, and CMake source selection accordingly.Scope
The PR is intended to provide the oneDNN-side dependency revision consumed by OpenVINO through
src/plugins/intel_cpu/thirdparty/onednn. It does not require OpenVINO to use an external oneDNN source tree.openvinotoolkit/openvino#36193