feat: add WaterTreatment class for Vitoset Aqua#761
Open
lackas wants to merge 3 commits into
Open
Conversation
Adds read-only support for the Vitoset Aqua water treatment station, covering the four functional areas exposed by the device: - Softener: salt days remaining, low-salt alert threshold - Consumption: current/max flow, daily/7-day/total volume - Leak detection: up to 5 sensors (status, leak, battery, RSSI, name, versions) plus configurable flow alert - Shutoff valve: position, motor state, holiday-mode flag Autodetect matches device model "VitosetAqua*" (e.g. VitosetAqua19D, VitosetAqua42D) and the "type:waterTreatment" role. Setters are intentionally left out for a follow-up: the IoT-scope dump contains no command definitions for this device.
CFenner
reviewed
Jun 14, 2026
Comment on lines
+37
to
+43
| @handleNotSupported | ||
| def getCurrentDayConsumption(self) -> int: | ||
| return int(self.getProperty("water.consumption.summary")["properties"]["currentDay"]["value"]) | ||
|
|
||
| @handleNotSupported | ||
| def getLastSevenDaysConsumption(self) -> int: | ||
| return int(self.getProperty("water.consumption.summary")["properties"]["lastSevenDays"]["value"]) |
Member
There was a problem hiding this comment.
Can we omit the daily / weekly end points? In my eyes it's not really necessary for HA, which is the first-class user of the this library.
| hw_props = self._readProperties(f"water.leakDetection.sensors.leakage.{slot}.version.hardware") | ||
| sw_props = self._readProperties(f"water.leakDetection.sensors.leakage.{slot}.version.software") | ||
| sensors.append({ | ||
| "slot": slot, |
Member
There was a problem hiding this comment.
These are not exposed as dedicated devices? What do you think of exposing them in a similar way than we do it with burners and compressors?
Mirror the Compressor / Burner pattern instead of returning a list of dicts: leakSensors returns LeakSensor objects with typed get* methods, discovery via getAvailableLeakSensorSlots filters on isEnabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type: New feature
Adds read-only support for the Vitoset Aqua water treatment station.
The Vitoset Aqua exposes four functional areas in its IoT-scope feature dump:
Autodetect matches device model
VitosetAqua*(e.g.VitosetAqua19D,VitosetAqua42D) and thetype:waterTreatmentrole.Setters intentionally deferred: the IoT-scope dump contains no command definitions for this device, so write operations cannot currently be implemented. Will follow up if/when commands surface.
Test data was added separately in #756.
Tests: 743 pass, includes new
test_VitosetAqua.py(82 lines) and 3 autodetect tests.