Base image improvements - #162
Conversation
Making note that copying in the rpms.repo and openssl-fips-provider-so workaround are upstream only
moved pbr to pythonbuilddep added necessary compilers to build dumb-init which is C based added builddeps with necessary rpms for building build necessary wheels in the builder stage and copy and install them Rotation to support downstream hermetic builds dumb-init is a C based project so it should be in a builder image not just built in the main image and installed
e99b3e8 to
d60388f
Compare
|
/lgtm |
| @@ -1,3 +1,2 @@ | |||
| crudini | |||
| pbr | |||
There was a problem hiding this comment.
Most services require pbr for runtime.
It's mostly due to the use of pbr.version.
I think that most of the service images install pbr HOWEVER, I am not sure of this, and removing pbr from pythondeps could break a few services
There was a problem hiding this comment.
if it is actually used as a runtime. it can get added back in. If it is actually a requirement it will get installed no matter what. but I'll add it back in
There was a problem hiding this comment.
done, update put it back in
Co-authored-by: Emma Foley <elfiesmelfie@users.noreply.github.com>
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fmount The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
144cedb
into
openstack-k8s-operators:main
4 participants
Two stage build with wheel
arg for UBI_BASE_IMAGE
comments for 2 skip in downstream commands
add tzdata and ensure /etc/localtime is set