Include metadefs data files in glance container image - #161
Merged
openshift-merge-bot[bot] merged 1 commit intoSep 2, 2026
Merged
Conversation
The metadefs JSON files from the glance source tree were not being copied into the container image, causing `glance-manage db_load_metadefs` to load nothing even when invoked correctly. This resulted in the metadefs resource_types API returning an empty list. Signed-off-by: Francesco Pantano <fpantano@redhat.com>
fmount
force-pushed
the
glance-metadefs
branch
from
September 1, 2026 20:53
9e7d93f to
980ccd3
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: konan-abhi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
Bot
merged commit Sep 2, 2026
8d871b8
into
openstack-k8s-operators:main
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
metadefsJSONfiles from the glance source tree were not being copied into the container image, causingglance-manage db_load_metadefsto load nothing even when invoked correctly. This resulted in themetadefsresource_types API returning an empty list [0].Even if they are served from the db, they are initialized from the json files provided in the path [1] (which is the default since we do not customize it, see [2]).
As usual, update sources as part of the patch.
[0] https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/logs//c56/rdoproject.org/c56192dd51ff40b89d7f981030d8a718/controller/ci-framework-data/tests/test_operator/tempest-tests-tempest/tempest_results.html
[1] https://opendev.org/openstack/glance/src/branch/master/glance/db/sqlalchemy/metadata.py#L40
[2] https://opendev.org/openstack/glance/src/branch/master/glance/db/sqlalchemy/metadata.py#L222