Skip to content

[cinder] Exclude unneeded requirements - #148

Open
elfiesmelfie wants to merge 1 commit into
openstack-k8s-operators:mainfrom
elfiesmelfie:cinder_exclude_requirements
Open

[cinder] Exclude unneeded requirements#148
elfiesmelfie wants to merge 1 commit into
openstack-k8s-operators:mainfrom
elfiesmelfie:cinder_exclude_requirements

Conversation

@elfiesmelfie

Copy link
Copy Markdown
Contributor

Remove the requirements that were previously excluded by the rpm package

https://github.com/rdo-packages/cinder-distgit/blob/c92ea047b9dd198f2863a1e220f9eab46dc00eed/openstack-cinder.spec#L5

Assisted-by: Claude Sonnet

@openshift-ci

openshift-ci Bot commented Aug 27, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign eharney for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@elfiesmelfie
elfiesmelfie requested a review from rebtoor August 27, 2026 15:06
@elfiesmelfie
elfiesmelfie force-pushed the cinder_exclude_requirements branch from 19f3aec to eea346f Compare August 27, 2026 15:06
@elfiesmelfie
elfiesmelfie force-pushed the cinder_exclude_requirements branch from eea346f to c70530a Compare August 27, 2026 15:07
@rebtoor

rebtoor commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

/lgtm

# zoneinfo library is provided in python3-libs which uses system installed tzdata.
# The distgit drops this from requirements.txt too.
# Source: https://raw.githubusercontent.com/rdo-packages/cinder-distgit/rpm-master/openstack-cinder.spec (line 5)
tzdata

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we installed this in the base contianer https://github.com/openstack-k8s-operators/tcib/blob/371f1136bba1b2821d105e73aa361de0faf7fd4a/container-images/tcib/base/base.yaml#L38

the tz to UTC to deal with a rhel regression in the past

openstack-k8s-operators/tcib@667788f

i guess we are exluding this from requirements.txt becuase we want to use the version form the disto instead.

this is required for logging and time stames to be correct sicne its used as part of the lcoale settings and python build in datatime modules

we do the same config here
https://github.com/openstack-k8s-operators/s2i-openstack-containers/blob/main/containers/base/Containerfile#L22-L23 and i belive we inherit the package form the base rhel ubi-minimal image

so i think this makes sense to exclude.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants