openstackclient: add novaclient and prometheus_client - #147
Open
lmiccini wants to merge 1 commit into
Open
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
The instanceha service (templates/instanceha/bin/instanceha.py in infra-operator) runs inside the openstackclient image and imports both novaclient and prometheus_client unconditionally at module load. In the tcib RPM-based image these were pulled in transitively, but the pip-based s2i image resolves strictly from the lockfile. Add python-novaclient and prometheus_client to pythondeps.txt and regenerate requirements.lock.master. Versions (18.13.0 / 0.25.0) come from upper-constraints.txt.master; the resolution added no new transitive dependencies. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
rebtoor
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The instanceha service (templates/instanceha/bin/instanceha.py in infra-operator) runs inside the openstackclient image and imports both novaclient and prometheus_client unconditionally at module load. In the tcib RPM-based image these were pulled in transitively, but the pip-based s2i image resolves strictly from the lockfile.
Add python-novaclient and prometheus_client to pythondeps.txt and regenerate requirements.lock.master. Versions (18.13.0 / 0.25.0) come from upper-constraints.txt.master; the resolution added no new transitive dependencies.