Skip to content

Set service_type in [keystone_authtoken] for access rule validation #664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
openshift-merge-bot merged 1 commit into from
Jun 26, 2026
+3 −1
Merged

Set service_type in [keystone_authtoken] for access rule validation #664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/cinder/config/00-global-defaults.conf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ project_name = service
{{ end -}}
service_token_roles_required = true
interface = internal
service_type = volumev3

@fmount fmount Jun 25, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question I asked in manila/glance about propagating [1].

[1] https://github.com/openstack-k8s-operators/cinder-operator/blob/main/internal/cinder/const.go#L35

{{ if (index . "Region") -}}
region_name = {{ .Region }}
{{ end -}}
Expand Down
3 changes: 2 additions & 1 deletion test/functional/cinder_controller_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,10 +335,11 @@ var _ = Describe("Cinder controller", func() {
cfg, err := ini.Load([]byte(configData))
Expect(err).ShouldNot(HaveOccurred(), "Should be able to parse config as INI")

// Verify region_name in [keystone_authtoken]
// Verify region_name and service_type in [keystone_authtoken]
section := cfg.Section("keystone_authtoken")
Expect(section).ShouldNot(BeNil(), "Should find [keystone_authtoken] section")
Expect(section.Key("region_name").String()).Should(Equal(testRegion))
Expect(section.Key("service_type").String()).Should(Equal("volumev3"))

// Verify region_name in [nova]
section = cfg.Section("nova")
Expand Down
Loading