Update Javadoc for libcobj/ui#825
Merged
yutaro-sakamoto merged 1 commit intoopensourcecobol:developfrom Apr 17, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Javadoc for the libcobj/ui package (per Issue #787), replacing TODO: 準備中 placeholders with documentation that reflects the current implementation behavior, without changing runtime logic.
Changes:
- Added/expanded class-level Javadoc for
CobolCallResult, its typed subclasses,CobolResultSet, andCobolResultSetException. - Clarified
@param,@return, and@throwstags for result accessors (including 1-based indexing semantics inCobolResultSet). - Applied
{@inheritDoc}to overridden getters in typed result subclasses.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolCallResult.java |
Documents base result type and exception behavior for unsupported getters. |
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolResultInt.java |
Adds class/constructor Javadoc and uses {@inheritDoc} for getInt(). |
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolResultDouble.java |
Adds class/constructor Javadoc and uses {@inheritDoc} for getDouble(). |
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolResultString.java |
Adds class/constructor Javadoc and uses {@inheritDoc} for getString(). |
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolResultSet.java |
Documents return code + multi-result access with 1-based index and clarifies throws conditions. |
libcobj/app/src/main/java/jp/osscons/opensourcecobol/libcobj/ui/CobolResultSetException.java |
Documents when the exception is thrown and clarifies constructor parameter meaning. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
Code review指摘事項はありません。バグおよび CLAUDE.md 準拠性を確認しました。 補足: 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
yutaro-sakamoto
approved these changes
Apr 17, 2026
5a11413
into
opensourcecobol:develop
544 of 588 checks passed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#787 に関する修正
概要
libcobj/uiパッケージのJavadocを整備した。TODO: 準備中となっていた各クラス・メソッドのJavadocを、実装内容に基づいた具体的な説明に置き換えた。変更点
CobolCallResult.java
getInt(),getDouble(),getString()の@return,@throwsを具体化CobolResultInt.java
@paramを具体化{@inheritDoc}を適用CobolResultDouble.java
@paramを具体化{@inheritDoc}を適用CobolResultString.java
@paramを具体化{@inheritDoc}を適用CobolResultSet.java
@paramを具体化getReturnCode()の@returnを具体化getString(int),getInt(int),getDouble(int)の@param,@return,@throwsを具体化(インデックスの範囲外と型の不一致の両方の例外条件を記載)CobolResultSetException.java
@paramを具体化その他