[WIP] Use ForceConsumer point force interface for applying Scholz2015GeometryPath forces#4331
Draft
nickbianco wants to merge 1 commit into
Draft
[WIP] Use ForceConsumer point force interface for applying Scholz2015GeometryPath forces#4331nickbianco wants to merge 1 commit into
ForceConsumer point force interface for applying Scholz2015GeometryPath forces#4331nickbianco wants to merge 1 commit into
Conversation
…ath` force calculations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #4276
Brief summary of changes
This PR replaces usages of
ForceConsumer::consumeBodySpatialVec()withForceConsumer::consumePointForce()for applying forces inScholz2015GeometryPath. This will enable downstream applications (e.g., OpenSim Creator) to visualize forces applied along muscle paths.Requires simbody/simbody#857 to be merged in Simbody first before merging here.
Testing I've completed
Ran
testScholz2015GeometryPath.cpptest suite.Looking for feedback on...
CHANGELOG.md (choose one)
This change is