OCPBUGS-86883:[release-4.14] bump google.golang.org/grpc to v1.79.3#94
OCPBUGS-86883:[release-4.14] bump google.golang.org/grpc to v1.79.3#94AkashMore08 wants to merge 4 commits into
Conversation
OCPBUGS-21576: bump(k8s,openshift) to address CVE-2023-44487 [4.14]
…ith manually bumping the otlptracegrpc to v1.17.0
|
@AkashMore08: This pull request references Jira Issue OCPBUGS-86883, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Caution Review failedAn error occurred during the review process. Please try again later. WalkthroughThis PR upgrades Go module dependencies in ChangesKubernetes and OpenShift Dependency Upgrade
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning Tools execution failed with the following error: Failed to run tools: 13 INTERNAL: Received RST_STREAM with code 2 (Internal server error) Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: AkashMore08 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@AkashMore08: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Address CVE-2026-33186 via transitive dependency update
This PR resolves CVE-2026-33186 for release-4.14 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.
Along with the CVE fix, we had to manually bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.17.0.
Why otlptracegrpc was bumped to v1.17.0?
Replacing google.golang.org/grpc with v1.64.1-sec.1 changes the module graph the new grpc version requires higher minimum versions of shared dependencies (google.golang.org/protobuf v1.33.0, golang.org/x/net v0.26.0, etc.). This forces go mod tidy to re-resolve the entire dependency tree, which exposes a pre-existing broken module resolution in otlptracegrpc v1.10.0 through v1.16.0.
These versions depend on internal packages (go.opentelemetry.io/otel/exporters/otlp/internal, go.opentelemetry.io/otel/exporters/otlp/internal/envconfig) that were resolved via local replace directives within the OpenTelemetry monorepo during development. When consumed from the Go module proxy, those local replaces are ignored, and go mod tidy fails because the enclosing module (go.opentelemetry.io/otel/exporters/otlp@v0.20.1) does not contain these packages.
otlptracegrpc v1.17.0 is the first version that inlined these internal packages and removed the broken external module dependency. This bump then transitively upgrades otelgrpc (from v0.35.0 to v0.49.0), the core otel SDK, and other shared dependencies are auto-resolved by go mod tidy.
Summary by CodeRabbit