Skip to content

OCPBUGS-86882:[release-4.15] bump google.golang.org/grpc to v1.79.3#93

Open
AkashMore08 wants to merge 1 commit into
openshift:release-4.15from
AkashMore08:OCPBUGS-86882-release-4.15
Open

OCPBUGS-86882:[release-4.15] bump google.golang.org/grpc to v1.79.3#93
AkashMore08 wants to merge 1 commit into
openshift:release-4.15from
AkashMore08:OCPBUGS-86882-release-4.15

Conversation

@AkashMore08

@AkashMore08 AkashMore08 commented Jun 4, 2026

Copy link
Copy Markdown

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 for release-4.15 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.

Along with the CVE fix, we had to manually bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.17.0.

Why otlptracegrpc was bumped to v1.17.0?

Replacing google.golang.org/grpc with v1.64.1-sec.1 changes the module graph the new grpc version requires higher minimum versions of shared dependencies (google.golang.org/protobuf v1.33.0, golang.org/x/net v0.26.0, etc.). This forces go mod tidy to re-resolve the entire dependency tree, which exposes a pre-existing broken module resolution in otlptracegrpc v1.10.0 through v1.16.0.

These versions depend on internal packages (go.opentelemetry.io/otel/exporters/otlp/internal, go.opentelemetry.io/otel/exporters/otlp/internal/envconfig) that were resolved via local replace directives within the OpenTelemetry monorepo during development. When consumed from the Go module proxy, those local replaces are ignored, and go mod tidy fails because the enclosing module (go.opentelemetry.io/otel/exporters/otlp@v0.20.1) does not contain these packages.

otlptracegrpc v1.17.0 is the first version that inlined these internal packages and removed the broken external module dependency. This bump then transitively upgrades otelgrpc (from v0.35.0 to v0.49.0), the core otel SDK, and other shared dependencies are auto-resolved by go mod tidy.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@AkashMore08: This pull request references Jira Issue OCPBUGS-86882, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-79934 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-79934 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from bparees and csrwng June 4, 2026 13:16
@openshift-ci

openshift-ci Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkashMore08
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bfd89ab1-cd71-4739-b4af-76b782018d0e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@AkashMore08: This pull request references Jira Issue OCPBUGS-86882, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.15.z) matches configured target version for branch (4.15.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-79934 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-79934 targets the "4.16.z" version, which is one of the valid target versions: 4.16.0, 4.16.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

Details

In response to this:

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 by addressing a vulnerability in the google.golang.org/grpc transitive dependency. To implement the fix for OCP release 4.15, the package has been repointed to our internal forked repository.

It now points to the custom patched version v1.64.1-sec.1, which contains the security fixes equivalent to the upstream 1.79.3 release.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@AkashMore08

Copy link
Copy Markdown
Author

/test e2e-aws-ovn

@AkashMore08

Copy link
Copy Markdown
Author

/test security

@AkashMore08 AkashMore08 force-pushed the OCPBUGS-86882-release-4.15 branch from f3e7cfd to cf3bee6 Compare June 5, 2026 06:19
…ith manually bumping the otlptracegrpc to v1.17.0
@AkashMore08 AkashMore08 force-pushed the OCPBUGS-86882-release-4.15 branch from cf3bee6 to 7400258 Compare June 5, 2026 07:05
@openshift-ci

openshift-ci Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

@AkashMore08: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 7400258 link false /test security

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants