Skip to content

Kueue downstream ci for s390x - #83236

Draft
Meghagaur wants to merge 8 commits into
openshift:mainfrom
Meghagaur:kueue-oz-s390x
Draft

Kueue downstream ci for s390x#83236
Meghagaur wants to merge 8 commits into
openshift:mainfrom
Meghagaur:kueue-oz-s390x

Conversation

@Meghagaur

@Meghagaur Meghagaur commented Aug 11, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

This PR adds downstream CI support for the Kueue operator release-1.4 on s390x. It configures 4.22 release inputs, build dependencies, resource requests, and a daily downstream end-to-end test.

The test uses the libvirt-s390x-vpn-oz profile and the kueue-operator-libvirt-s390x workflow. The workflow provisions ephemeral s390x OpenShift 4.21 clusters on remote IBM Z libvirt hypervisors, then performs test execution, log collection, and cleanup.

@openshift-ci openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @Meghagaur. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Meghagaur
Once this PR has been reviewed and has the lgtm label, please assign rphillips for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 985362e9-ee4a-4923-b94d-e112d065c1bf

📥 Commits

Reviewing files that changed from the base of the PR and between 0f1ccb9 and 4de17cf.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/kueue-operator/openshift-kueue-operator-release-1.4-periodics.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/kueue-operator/openshift-kueue-operator-release-1.4-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (4)
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/OWNERS
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.metadata.json
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.yaml
🚧 Files skipped from review as they are similar to previous changes (4)
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.yaml
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/OWNERS
  • ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.metadata.json
  • ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml

Walkthrough

The PR adds a release-1.4 Kueue operator configuration for s390x libvirt testing. It defines the cluster workflow, release inputs, daily end-to-end test, ownership, and generated metadata.

Changes

Kueue s390x libvirt CI

Layer / File(s) Summary
Release configuration and test inputs
ci-operator/config/openshift/kueue-operator/openshift-kueue-operator-release-1.4__libvirt-s390x.yaml
Adds build images, bundle substitutions, repository inputs, release dependencies, resource requests, and a daily downstream end-to-end test.
s390x libvirt workflow
ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.yaml
Defines cluster provisioning, libvirt setup, diagnostics, cleanup, and s390x environment settings.
Workflow ownership metadata
ci-operator/step-registry/kueue-operator/libvirt-s390x/OWNERS, ci-operator/step-registry/kueue-operator/libvirt-s390x/kueue-operator-libvirt-s390x-workflow.metadata.json
Adds approvers, reviewers, and generated workflow metadata.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant Prow
  participant KueueReleaseConfig
  participant LibvirtS390xWorkflow
  participant Boskos
  participant IBMZLibvirtHypervisors
  participant DownstreamE2ETest
  Prow->>KueueReleaseConfig: Start daily release test
  KueueReleaseConfig->>LibvirtS390xWorkflow: Start s390x workflow
  LibvirtS390xWorkflow->>Boskos: Acquire managed resources
  LibvirtS390xWorkflow->>IBMZLibvirtHypervisors: Provision ephemeral OpenShift cluster
  LibvirtS390xWorkflow->>DownstreamE2ETest: Run operator end-to-end test
  LibvirtS390xWorkflow->>IBMZLibvirtHypervisors: Gather logs and clean up
Loading

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error, 1 inconclusive)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The new workflow activates libvirt cleanup and gather steps that log leased hypervisor and cluster node hostnames, exposing internal hostnames in job logs. Redact or omit hostnames from cleanup and gather log messages, and retain only non-sensitive resource identifiers in public CI output.
Ote Binary Stdout Contract ❓ Inconclusive Need verify the complete PR diff and referenced test chains before deciding whether this configuration activates an OTE stdout violation. Inspect the changed job/config files and referenced OTE test sources.
✅ Passed checks (13 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: adding Kueue downstream CI support for s390x.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR diff adds or updates only CI YAML, JSON, and OWNERS files; it changes zero Go files and adds no Ginkgo It, Describe, Context, or When test titles.
Test Structure And Quality ✅ Passed The PR changes only CI YAML, OWNERS, metadata, and generated Prow jobs; the diff has 0 Go or test files and no added Ginkgo constructs, so this check is inapplicable.
Microshift Test Compatibility ✅ Passed The PR changes only YAML, JSON, and OWNERS files; the diff adds no Ginkgo tests or test declarations subject to MicroShift compatibility checks.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The diff adds only CI YAML, job, workflow, metadata, and OWNERS files; it adds no Ginkgo test source or It/Describe/Context/When constructs, so the SNO check is inapplicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff adds CI configuration, Prow jobs, ownership metadata, and a libvirt workflow; it adds no deployment, operator, controller, or topology-sensitive scheduling constraints.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds CI YAML and workflow metadata only. It adds no Ginkgo test declarations or test source; the new job reuses the existing downstream chain.
No-Weak-Crypto ✅ Passed The full PR diff adds only YAML, OWNERS, and metadata JSON. Precise scans found no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons.
Container-Privileges ✅ Passed PR additions are CI configuration and workflow metadata; scans found no privileged:true, hostPID/hostNetwork/hostIPC, SYS_ADMIN, allowPrivilegeEscalation:true, or explicit root settings. The capabi...
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sivaramsingana

Copy link
Copy Markdown

/ok-to-test

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@sivaramsingana: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@veera-damisetti

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@bj2122

bj2122 commented Aug 11, 2026

Copy link
Copy Markdown

/ok-to-test

@Meghagaur

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Meghagaur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@Meghagaur

Copy link
Copy Markdown
Author

/ok-to-test

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Meghagaur

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Meghagaur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@Meghagaur

Copy link
Copy Markdown
Author

/retest

@Meghagaur

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Meghagaur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

@Meghagaur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22 4de17cf link unknown /pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@Meghagaur: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-ci-bundle-kueue-bundle openshift/kueue-operator presubmit Presubmit changed
pull-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-images openshift/kueue-operator presubmit Presubmit changed
periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22 N/A periodic Periodic changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@Meghagaur

Copy link
Copy Markdown
Author

/pj-rehearse periodic-ci-openshift-kueue-operator-release-1.4-libvirt-s390x-test-e2e-downstream-4-22

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@Meghagaur: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants