Skip to content

Use FIPS VPN workflow for IBM Z TechPreview conformance-parallel jobs - #83225

Open
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:ibmz-techpreview-conformance-parallel-fips-4.23-5.1
Open

Use FIPS VPN workflow for IBM Z TechPreview conformance-parallel jobs#83225
ibm-adarsh wants to merge 1 commit into
openshift:mainfrom
ibm-adarsh:ibmz-techpreview-conformance-parallel-fips-4.23-5.1

Conversation

@ibm-adarsh

@ibm-adarsh ibm-adarsh commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Switch IBM Z (s390x) TechPreviewNoUpgrade conformance-parallel periodics to openshift-e2e-libvirt-vpn-fips and set FIPS_ENABLED: "true" for OCP 4.23, 5.0, and 5.1
  • Jobs updated:
    • ocp-e2e-ovn-techpreview-multi-z-z (nightly-4.23)
    • ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z (nightly-5.0, nightly-5.1)
  • Serial TechPreview and Power jobs are unchanged

Test plan

  • Confirm only the three multiarch nightly configs above changed
  • /pj-rehearse one or more of the affected periodics, or /pj-rehearse skip if appropriate
  • Verify install enables FIPS and the fips-check pre-step runs via the FIPS VPN workflow

Summary by CodeRabbit

The PR updates three IBM Z (s390x) TechPreviewNoUpgrade conformance-parallel nightly jobs for OCP 4.23, 5.0, and 5.1. These jobs now use the openshift-e2e-libvirt-vpn-fips workflow and set FIPS_ENABLED: "true" to validate FIPS installation and execution.

Serial TechPreview and Power jobs remain unchanged.

Enable FIPS validation on s390x TechPreviewNoUpgrade conformance-parallel
periodics for 4.23, 5.0, and 5.1 by switching to openshift-e2e-libvirt-vpn-fips.
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @ibm-adarsh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

Three multiarch OVN TechPreview jobs now enable FIPS and use the FIPS-specific libvirt VPN workflow.

Changes

FIPS multiarch libvirt jobs

Layer / File(s) Summary
Configure FIPS libvirt workflows
ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-4.23.yaml, ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.0.yaml, ci-operator/config/openshift/multiarch/openshift-multiarch-main__nightly-5.1.yaml
The three OVN TechPreview jobs set FIPS_ENABLED to "true" and use openshift-e2e-libvirt-vpn-fips. Existing conformance and external-DNS settings remain unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

Suggested reviewers: neha-dot-yadav


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The three changed jobs now invoke fips-check, which logs each cluster node name via ${nodes[i]}; node names may expose internal hostnames. Redact, hash, or omit node names in fips-check status messages before enabling this workflow for these jobs.
✅ Passed checks (14 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only three YAML workflow/env entries and adds no Ginkgo test titles or dynamic test-name expressions.
Test Structure And Quality ✅ Passed The PR changes only three YAML ci-operator configs and adds no Ginkgo test code, so the listed test-quality criteria are not applicable.
Microshift Test Compatibility ✅ Passed The pull request changes only three YAML CI configurations and adds no Ginkgo tests or MicroShift-incompatible API usage.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only three YAML CI configurations and adds no Ginkgo tests or test bodies, so the SNO multi-node compatibility check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed The diff changes only three CI YAML files, adding FIPS_ENABLED and selecting an existing FIPS workflow; it adds no deployment, controller, or scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The HEAD patch changes only three YAML configuration files and no Go or OTE source, so it introduces no process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The pull request changes only three CI YAML files; it adds no Ginkgo tests or networking code, so this compatibility check is not applicable.
No-Weak-Crypto ✅ Passed The commit adds only FIPS_ENABLED and an existing FIPS workflow reference; no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons occur.
Container-Privileges ✅ Passed The diff changes only three CI YAML files and adds FIPS settings/workflow names; no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation declarations were added.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: applying the FIPS VPN workflow to IBM Z TechPreview conformance-parallel jobs.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ibm-adarsh
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested review from amrutp-redhat and wking August 11, 2026 06:00
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@ibm-adarsh: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z N/A periodic Ci-operator config changed
periodic-ci-openshift-multiarch-main-nightly-5.1-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z N/A periodic Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@sandisamp

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

@ibm-adarsh: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z 6e0089c link unknown /pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z
ci/rehearse/periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z 6e0089c link unknown /pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-5.0-ocp-e2e-ovn-techpreview-remote-libvirt-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@ibm-adarsh

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-openshift-multiarch-main-nightly-4.23-ocp-e2e-ovn-techpreview-multi-z-z

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@ibm-adarsh: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants