Skip to content

Remove post wait ibu - #83155

Open
shaior wants to merge 1 commit into
openshift:mainfrom
shaior:enable4.20
Open

Remove post wait ibu#83155
shaior wants to merge 1 commit into
openshift:mainfrom
shaior:enable4.20

Conversation

@shaior

@shaior shaior commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

The telcov10n functional CNF RAN IBU workflow no longer runs the wait step during its post phase. The cnf-ran-ztp-tests CI configuration now includes ReportPortal launch, template, URL, and output-file environment variables.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 276294e8-c86c-40c5-9cfb-d126a11c8c48

📥 Commits

Reviewing files that changed from the base of the PR and between e1720aa and d551c10.

📒 Files selected for processing (2)
  • ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-ibu-4.20.yaml
  • ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.yaml
💤 Files with no reviewable changes (1)
  • ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/telcov10n-functional-cnf-ran-ibu-workflow.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
  • ci-operator/config/openshift-kni/eco-ci-cd/openshift-kni-eco-ci-cd-main__cnf-ran-ibu-4.20.yaml

Walkthrough

The CNF RAN IBU test configuration now includes ReportPortal settings. The workflow no longer includes a post phase that invokes the wait step.

Changes

CNF RAN IBU CI updates

Layer / File(s) Summary
ReportPortal configuration and workflow cleanup
ci-operator/config/openshift-kni/eco-ci-cd/...cnf-ran-ibu-4.20.yaml, ci-operator/step-registry/telcov10n/functional/cnf-ran/ibu/...workflow.yaml
Added ReportPortal launch, template, and output-file environment variables. Removed the workflow post section and its wait step.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: smg247, sosiouxme

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing the post wait step from the IBU workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The patch changes only workflow YAML and ReportPortal environment variables; it adds or modifies no Ginkgo test-title APIs or dynamic test names.
Test Structure And Quality ✅ Passed The patch changes only two YAML files, adds ReportPortal environment variables, and removes a workflow wait step; it changes no Ginkgo test code.
Microshift Test Compatibility ✅ Passed The PR changes only two YAML files, adds ReportPortal environment variables, and removes a wait step; it adds no Ginkgo e2e tests or test declarations.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only two YAML files, adding ReportPortal variables and removing a workflow wait step; it adds no Ginkgo e2e tests requiring SNO review.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only a CI workflow and ReportPortal environment variables; it adds no deployment, operator, controller, or topology-related scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The patch changes only CI YAML: it removes a workflow wait step and adds ReportPortal environment variables; it contains no OTE binary or process-level Go stdout code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The patch changes only two YAML files, removes a workflow wait step, and adds ReportPortal environment variables; it adds no Ginkgo tests or network code.
No-Weak-Crypto ✅ Passed The commit changes only YAML workflow and reporting variables; the added-line and changed-file scans found no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, or crypto implementation.
Container-Privileges ✅ Passed The diff adds only three report environment variables and removes a wait step; no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, root, or allowPrivilegeEscalation settings exist.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only ReportPortal identifiers and a filename, and removes a wait step. It adds no logging statements, passwords, tokens, API keys, PII, or customer data.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@shaior

shaior commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-ci
openshift-ci Bot requested review from smg247 and sosiouxme August 10, 2026 05:31
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@eifrach

eifrach commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@shaior

shaior commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@shaior: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@eifrach

eifrach commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD e1720aa and 2 for PR HEAD 3f6886d in total

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 10, 2026
@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: eifrach, shaior

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot removed the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 10, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@shaior: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.16-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.18-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.22-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-5.0-cnf-ran-ztp-tests N/A periodic Registry content changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-4.20-cnf-ran-ztp-tests N/A periodic Ci-operator config changed
periodic-ci-openshift-kni-eco-ci-cd-main-cnf-ran-ibu-5.1-cnf-ran-ztp-tests N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

@shaior: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants