Skip to content

setup assisted-installer version v2.55 - #83151

Open
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-12c9eefd-e393-49cd-a1de-a5c68fec936b
Open

setup assisted-installer version v2.55#83151
danmanor wants to merge 1 commit into
openshift:mainfrom
danmanor:assisted-installer/setup-version-v2.55-12c9eefd-e393-49cd-a1de-a5c68fec936b

Conversation

@danmanor

@danmanor danmanor commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • Updated Assisted Installer v2.55 CI configurations for both the agent and installer repositories.
  • Set always_run: false for subsystem-test and e2e-metal-assisted where applicable.
  • Replaced skip_if_only_changed with pipeline_skip_if_only_changed to apply skip rules at the pipeline level.

@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danmanor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 9, 2026
@coderabbitai

coderabbitai Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 7bca3801-de0f-428e-ab05-10ae92b5e270

📥 Commits

Reviewing files that changed from the base of the PR and between 6fd6d16 and d5efe48.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift/assisted-installer/openshift-assisted-installer-v2.55-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/openshift/assisted-installer-agent/openshift-assisted-installer-agent-v2.55.yaml
  • ci-operator/config/openshift/assisted-installer/openshift-assisted-installer-v2.55.yaml

Walkthrough

The v2.55 Assisted Installer CI configurations now disable unconditional execution for selected tests and apply changed-file exclusions at the pipeline level.

Changes

Assisted Installer CI configuration

Layer / File(s) Summary
Pipeline test scheduling
ci-operator/config/openshift/assisted-installer-agent/..., ci-operator/config/openshift/assisted-installer/...
The subsystem-test and e2e-metal-assisted definitions set always_run: false. Their changed-file filters use pipeline_skip_if_only_changed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the assisted-installer version setup, which matches the main configuration changes for v2.55.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit changes only CI YAML and generated job metadata; added test identifiers are static, with no Ginkgo titles or dynamic values such as nodes, namespaces, timestamps, UUIDs, or IPs.
Test Structure And Quality ✅ Passed The commit changes only four YAML CI configuration files; it adds scheduling metadata and contains no Ginkgo test code, cluster operations, or assertions to review.
Microshift Test Compatibility ✅ Passed The PR changes only CI config and generated presubmit YAML; it adds no Ginkgo tests or test code, so MicroShift API compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only four CI YAML files; it adds no Ginkgo tests or test implementation, so SNO compatibility checks do not apply.
Topology-Aware Scheduling Compatibility ✅ Passed The commit changes only CI test-selection fields and generated presubmit annotations; it adds no deployment, operator, controller, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only four YAML CI configuration/job files; it adds no OTE binary code, process-level setup, or stdout writes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The commit changes only CI YAML configuration and generated presubmits; it adds no Ginkgo test code, IPv4 assumptions, or external connectivity behavior.
No-Weak-Crypto ✅ Passed The PR changes only CI YAML scheduling fields and generated annotations; the complete patch has no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto code, or secret comparisons.
Container-Privileges ✅ Passed The changed CI YAML and generated job files add no privileged:true, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, or root security settings.
No-Sensitive-Data-In-Logs ✅ Passed The PR changes only test scheduling fields (always_run and pipeline_skip_if_only_changed); it adds no logging or sensitive-data output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from carbonin and danielerez August 9, 2026 15:22
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danmanor: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-assisted-installer-v2.55-e2e-metal-assisted openshift/assisted-installer presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-e2e-metal-assisted openshift/assisted-installer-agent presubmit Ci-operator config changed
pull-ci-openshift-assisted-installer-agent-v2.55-subsystem-test openshift/assisted-installer-agent presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-ci

openshift-ci Bot commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

@danmanor: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants