Skip to content

ROSAENG-61951 | chore: add codecov jobs - #82291

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gdbranco:chore/61951
Jul 22, 2026
Merged

ROSAENG-61951 | chore: add codecov jobs#82291
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
gdbranco:chore/61951

Conversation

@gdbranco

@gdbranco gdbranco commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Adds Codecov coverage collection and publishing jobs to the OpenShift CI workflow for the osd-fleet-manager repository. The jobs prepare the Go, AWS, database, and secret environments, run make codecov with the Codecov secret, and publish coverage results after submission.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Walkthrough

The OSD Fleet Manager OpenShift CI workflow adds coverage and publish-coverage steps that prepare the integration environment and database, run make codecov in a nested-podman container, mount the Codecov secret, and mark publishing as postsubmit.

Changes

Coverage CI workflow

Layer / File(s) Summary
Coverage and publishing steps
ci-operator/config/openshift-online/osd-fleet-manager/...yaml
Adds coverage and publish-coverage Prow steps with environment setup, database preparation, Codecov secret mounting, nested-podman execution, and postsubmit publishing.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

Suggested labels: lgtm, approved


Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 error)

Check name Status Explanation Resolution
No-Sensitive-Data-In-Logs ❌ Error The presubmit coverage job mounts osd-fleet-manager-codecov and runs make codecov on PRs, so PR-controlled output could leak the token. Remove the Codecov secret from coverage; keep it only on publish-coverage or switch coverage to a tokenless path.
✅ Passed checks (14 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding Codecov-related CI jobs/steps.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR only adds Prow CI steps in a YAML config; no Ginkgo test titles or dynamic test names were introduced.
Test Structure And Quality ✅ Passed PR only changes ci-operator job YAML; no Ginkgo test code, assertions, or timeout patterns were modified, so this check is not applicable.
Microshift Test Compatibility ✅ Passed No Ginkgo tests were added; this PR only adds CI coverage job config, so MicroShift compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR only adds CI coverage/publish-coverage jobs; no new Ginkgo/e2e tests or multi-node assumptions were introduced, so SNO check is not applicable.
Topology-Aware Scheduling Compatibility ✅ Passed Only ci-operator job config changed; no manifests/controllers or scheduling constraints were added.
Ote Binary Stdout Contract ✅ Passed Only ci-operator YAML changed; no OTE binary code or stdout/logging setup was modified, so the stdout contract check is not applicable.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed No Ginkgo test code was added; the PR only changes ci-operator YAML/job configs, so the IPv6/disconnected test check is not applicable.
No-Weak-Crypto ✅ Passed The PR only adds CI job YAML for codecov; the changed files contain no MD5/SHA1/DES/RC4/3DES/Blowfish/ECB, custom crypto, or secret comparisons.
Container-Privileges ✅ Passed The PR adds no direct privileged, hostPID/Network/IPC, SYS_ADMIN, or allowPrivilegeEscalation settings; only nested-podman capability is present.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Checkov (3.3.8)
ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml

Traceback (most recent call last):
File "/usr/local/bin/checkov", line 2, in
from checkov.main import Checkov
ModuleNotFoundError: No module named 'checkov'


Comment @coderabbitai help to get the list of available commands.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@gdbranco: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-online-osd-fleet-manager-main-coverage openshift-online/osd-fleet-manager presubmit Presubmit changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In
`@ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml`:
- Around line 99-117: Remove the osd-fleet-manager-codecov entry from the
coverage job’s secrets configuration. Keep the secret available only to
publish-coverage, or otherwise ensure coverage uses a tokenless presubmit path
while preserving its existing commands.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 85eef3dd-b812-424b-be34-a533952806bf

📥 Commits

Reviewing files that changed from the base of the PR and between 2faec59 and c2c55d4.

⛔ Files ignored due to path filters (2)
  • ci-operator/jobs/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main-postsubmits.yaml is excluded by !ci-operator/jobs/**
  • ci-operator/jobs/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main-presubmits.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (1)
  • ci-operator/config/openshift-online/osd-fleet-manager/openshift-online-osd-fleet-manager-main.yaml

@gdbranco

Copy link
Copy Markdown
Contributor Author

/pj-rehearse pull-ci-openshift-online-osd-fleet-manager-main-coverage

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@gdbranco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gdbranco

Copy link
Copy Markdown
Contributor Author

/pj-rehearse ack

@gdbranco

Copy link
Copy Markdown
Contributor Author

/approve

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@gdbranco: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Jul 22, 2026
@andrebeltrami

Copy link
Copy Markdown

/approve

@andrebeltrami andrebeltrami left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jul 22, 2026
@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrebeltrami, gdbranco

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit a30e29a into openshift:main Jul 22, 2026
17 checks passed
apahim pushed a commit to apahim/release that referenced this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants