MON-4471: test/extended/prometheus: move alert tests to "Test Framework" - #30703
MON-4471: test/extended/prometheus: move alert tests to "Test Framework"#30703simonpasquier wants to merge 1 commit into
Conversation
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
openshift-ci
Bot
added
the
approved
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New Test Risks for sha: 616e9bd
New tests seen in this PR at sha: 616e9bd
|
simonpasquier
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@simonpasquier: This pull request references MON-4471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.22.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Sorry had this open days ago and lost track of it. /lgtm |
|
@dgoodwin I'm confused because the renamed test doesn't appear in the e2e output logs. Is it because we need to merge openshift-eng/ci-test-mapping#579? |
|
It looks like only one job ran it #30703 (comment) Probably a good reason why that is but may need investigation, #forum-ocp-release-oversight may be able to help |
616e9bd to
814e9f7
Compare
|
/test images |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 814e9f7
|
814e9f7 to
854b5da
Compare
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 854b5da
|
openshift-ci
Bot
added
the
needs-rebase
854b5da to
28976f9
Compare
openshift-ci
Bot
removed
the
needs-rebase
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe Prometheus test suite adds config API group checks for rule-evaluation failures and unexpected firing alerts. It applies standard and platform-specific alert exclusions and removes duplicate checks. ChangesPrometheus alert validation
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (14 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@simonpasquier: This pull request references MON-4471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@test/extended/prometheus/prometheus.go`:
- Line 624: Replace the context.TODO() instances in both Ginkgo g.It specs with
the provided g.SpecContext, updating each spec signature to accept it. Pass that
context through NewPrometheusClient, RunQueries, and IsManagedServiceCluster so
Prometheus operations honor spec cancellation.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 518bf721-8f75-46ff-8916-0648d53b7183
📒 Files selected for processing (1)
test/extended/prometheus/prometheus.go
28976f9 to
99099a9
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Scheduling required tests: |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: 99099a9
|
|
/hold |
|
/verified by CI |
openshift-ci
Bot
added
the
do-not-merge/hold
|
@simonpasquier: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
verified
This commit renames 2 tests related to alerting rules: * 1 test checking that no rule fails to evaluate. * 1 test checking that there's no firing alert other than approved exceptions. When these tests fail, the associated Jira used to be assigned to the Monitoring component because of the "sig-instrumentation" prefix. But in practice, it can be any component and monitoring is (often) only the messenger. The tests are renamed with the [Jira:"Test Framework"] prefix instead which redirects the tickets to TRT. Signed-off-by: Simon Pasquier <spasquie@redhat.com>
99099a9 to
d26784b
Compare
openshift-ci-robot
removed
the
verified
|
@simonpasquier: This pull request references MON-4471 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci
Bot
added
the
ready-for-human-review
|
Scheduling required tests: |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, machine424, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@simonpasquier: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Risk analysis has seen new tests most likely introduced by this PR. New tests seen in this PR at sha: d26784b
|
4 participants
This commit renames 2 tests related to alerting rules:
When these tests fail, the associated Jira used to be assigned to the Monitoring component because of the "sig-instrumentation" prefix. But in practice, it can be any component and monitoring is (often) only the messenger. The tests are renamed with the [Jira:"Test Framework"] prefix instead which redirects the tickets to TRT.
Summary by CodeRabbit