WIP: OCPBUGS-105786: Include all projects when sending initial events, not just the bookmark alone

[jacobsee]

Summary by CodeRabbit

• Bug Fixes
  • Improved project watch behavior for initial-event requests.
  • Ensured existing projects are delivered only when bookmark support is enabled.
  • Preserved the ability to request all existing projects using resource version 0.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jacobsee: This pull request references Jira Issue OCPBUGS-105786, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: bff036fa-1ab8-4d14-8069-200ac9d54560

📥 Commits

Reviewing files that changed from the base of the PR and between 5ab4a0e and c59fa02.

📒 Files selected for processing (1)

• pkg/project/apiserver/registry/project/proxy/proxy.go

---

Walkthrough

The project watch proxy now requires both SendInitialEvents and AllowWatchBookmarks for initial project delivery. Resource version "0" continues to include all existing projects.

Changes

Project watch behavior

Layer / File(s)	Summary
Initial event eligibility pkg/project/apiserver/registry/project/proxy/proxy.go	Watch requires SendInitialEvents and AllowWatchBookmarks before delivering initial projects. Resource version "0" retains its existing behavior.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Mergeability Score: ⚪ Minimal · up to c59fa

This localized change has no identified merge-blocking risk in the supplied evidence and is merge-ready after normal checks and review.

Suggested reviewers: tchap

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Test Structure And Quality	❓ Inconclusive	Placeholder while evidence is gathered.	Need inspect the proxy diff and related Ginkgo tests.

✅ Passed checks (14 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the main change: include all projects during initial events instead of sending only a bookmark.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The commit changes only proxy.go Watch logic; it adds no Ginkgo test file or test title, so the stated naming failure condition is not introduced.
Microshift Test Compatibility	✅ Passed	The diff changes only proxy.go's Watch method and adds no Ginkgo tests or test files, so the MicroShift test compatibility check is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The pull request changes only proxy.go and adds no Ginkgo e2e tests, so the SNO multi-node test compatibility check does not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only project watch event selection in proxy.go; it adds no manifests, operators, controllers, replicas, affinities, selectors, tolerations, spread constraints, or PDBs.
Ote Binary Stdout Contract	✅ Passed	The diff changes only REST.Watch option logic; it adds no fmt, log, klog, os.Stdout, or process-level setup writes. The OTE stdout contract is unaffected.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The patch changes only proxy.go and adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The diff only changes Watch option handling for initial project events; it introduces no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR changes only project watch logic in proxy.go. The diff adds no container/Kubernetes manifest or privilege settings such as privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, or allowPrivi...
No-Sensitive-Data-In-Logs	✅ Passed	The commit only changes Watch eligibility logic; its diff adds no logging, and the affected file contains no log, print, or sensitive-data logging call.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• pkg/project/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jacobsee]

/payload-job periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview

[openshift-ci]

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f12c2e80-96a9-11f1-9331-cb89d25660b4-0

[openshift-ci-robot]

@jacobsee: This pull request references Jira Issue OCPBUGS-105786, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Summary by CodeRabbit

• Bug Fixes
• Improved project watch behavior for initial-event requests.
• Ensured existing projects are delivered only when bookmark support is enabled.
• Preserved the ability to request all existing projects using resource version 0.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[jacobsee]

/payload-aggregate periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview 10

[openshift-ci]

@jacobsee: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

• periodic-ci-openshift-release-main-ci-5.0-e2e-gcp-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/e1c3e590-96cd-11f1-9f57-82a7736d529e-0

[jacobsee]

/close not handling the problem this way - disabling watchlist for this resource for now