Skip to content

NO-JIRA: route: Update OWNERS #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alebedev87 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

NO-JIRA: route: Update OWNERS #558

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 23 additions & 10 deletions pkg/route/OWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,29 @@
reviewers:
- smarterclayton
- pweil-
- imcsk8
- knobunc
- ironcladlou
- pecameron
- pravisankar
- rajatchopra
- jacobtanenbaum
- Miciah

@ingvagabund ingvagabund Jun 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a lot of names where I am not sure to which team each belongs to. What about to create an alias under https://github.com/openshift/openshift-apiserver/blob/main/OWNERS_ALIASES? Assuming everyone added into both pools are from the same network oriented team(s)?

- alebedev87
- rikatz
- candita
- rfredette
- gcs278
- davidesalerno
- bentito
- Thealisyed
- grzpiotrowski
approvers:
- knobunc
- Miciah
- alebedev87
- rikatz
- candita
- rfredette
- gcs278
- davidesalerno
- bentito
- Thealisyed
- grzpiotrowski
Comment on lines +14 to +24

@coderabbitai coderabbitai Bot Sep 17, 2025

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

🧩 Analysis chain

Scope approvers to a small, trusted subset (align with PR intent).

Approvers gate merges. The PR description only calls out adding Miciah (and keeping existing leadership), but this change elevates 11 people to approvers. Recommend limiting approvers to a minimal set and adding others later as needed.

Apply this minimal change if that matches intent:

 approvers:
-  - knobunc
-  - Miciah
-  - alebedev87
-  - rikatz
-  - candita
-  - rfredette
-  - gcs278
-  - davidesalerno
-  - bentito
-  - Thealisyed
-  - grzpiotrowski
+  - knobunc
+  - Miciah

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "=== Repository root: $(pwd) ==="
echo

echo "=== Check file path ==="
if [ -f pkg/route/OWNERS ]; then
  echo "FOUND: pkg/route/OWNERS"
else
  echo "MISSING: pkg/route/OWNERS"
  exit 0
fi

echo
echo "=== Show file with line numbers ==="
nl -ba pkg/route/OWNERS | sed -n '1,200p' || true

echo
echo "=== Show 'approvers:' block ==="
awk 'BEGIN{in=0} /approvers:/{in=1; print; next} in && /^$/{exit} in{print}' pkg/route/OWNERS || true

echo
echo "=== Git log for this file (last 10 commits) ==="
git --no-pager log --pretty=format:'%h %ad %an %s' --date=short -n 10 -- pkg/route/OWNERS || true

echo
echo "=== Diff vs origin/main (if available), else HEAD^..HEAD ==="
if git rev-parse --verify origin/main >/dev/null 2>&1; then
  git --no-pager diff --color=never origin/main -- pkg/route/OWNERS || true
else
  if git rev-parse HEAD^ >/dev/null 2>&1; then
    git --no-pager diff --color=never HEAD^ -- pkg/route/OWNERS || true
  else
    echo "No origin/main or parent commit available to diff against."
  fi
fi

Length of output: 1861

Restrict approvers to a minimal, trusted set (pkg/route/OWNERS — approvers).

PR elevates 11 users to approvers though description only mentions adding Miciah; approvers gate merges — keep only knobunc and Miciah.

 approvers:
-  - knobunc
-  - Miciah
-  - alebedev87
-  - rikatz
-  - candita
-  - rfredette
-  - gcs278
-  - davidesalerno
-  - bentito
-  - Thealisyed
-  - grzpiotrowski
+  - knobunc
+  - Miciah
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
- knobunc
- Miciah
- alebedev87
- rikatz
- candita
- rfredette
- gcs278
- davidesalerno
- bentito
- Thealisyed
- grzpiotrowski
approvers:
- knobunc
- Miciah
🤖 Prompt for AI Agents 
In pkg/route/OWNERS around lines 14 to 24, the approvers list incorrectly
includes 11 users though the PR described adding only Miciah; restrict the
approvers to the minimal trusted set by removing all additional usernames and
leaving only "knobunc" and "Miciah" in the approvers section so merges remain
gated to those two trusted approvers.

emeritus_approvers:
- smarterclayton

@ingvagabund ingvagabund Jun 11, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

smarterclayton left few years back too

- pweil-
- knobunc
- ironcladlou
- rajatchopra
- ironcladlou