Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .coderabbit.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
inheritance: true
reviews:
path_instructions:
- path: "pkg/controller/kubelet-config/**"
instructions: |
Treat KubeletConfig override changes as platform-safety changes. Flag user overrides of platform-owned fields or feature gates, unaccounted MachineConfigPool rollout and reboot impact, and changes lacking Node-team review or focused validation coverage.
37 changes: 37 additions & 0 deletions pkg/controller/kubelet-config/kubelet_config_controller_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ import (
"sort"
"strings"
"testing"
"time"

ign3types "github.com/coreos/ignition/v2/config/v3_5/types"
"github.com/stretchr/testify/assert"
Expand Down Expand Up @@ -1018,6 +1019,42 @@ func TestKubeletConfigDenylistedOptions(t *testing.T) {
},
},
},
{
name: "user cannot configure shutdownGracePeriod through GracefulNodeShutdown",
config: &kubeletconfigv1beta1.KubeletConfiguration{
ShutdownGracePeriod: metav1.Duration{Duration: 30 * time.Second},
FeatureGates: map[string]bool{"GracefulNodeShutdown": true},
},
},
{
name: "user cannot configure shutdownGracePeriodCriticalPods through GracefulNodeShutdown",
config: &kubeletconfigv1beta1.KubeletConfiguration{
ShutdownGracePeriodCriticalPods: metav1.Duration{Duration: 10 * time.Second},
FeatureGates: map[string]bool{"GracefulNodeShutdown": true},
},
},
{
name: "user cannot configure shutdownGracePeriodByPodPriority through GracefulNodeShutdownBasedOnPodPriority",
config: &kubeletconfigv1beta1.KubeletConfiguration{
ShutdownGracePeriodByPodPriority: []kubeletconfigv1beta1.ShutdownGracePeriodByPodPriority{{
Priority: 0,
ShutdownGracePeriodSeconds: 30,
}},
FeatureGates: map[string]bool{"GracefulNodeShutdownBasedOnPodPriority": true},
},
},
{
name: "user cannot supply GracefulNodeShutdown feature gate",
config: &kubeletconfigv1beta1.KubeletConfiguration{
FeatureGates: map[string]bool{"GracefulNodeShutdown": true},
},
},
{
name: "user cannot supply GracefulNodeShutdownBasedOnPodPriority feature gate",
config: &kubeletconfigv1beta1.KubeletConfiguration{
FeatureGates: map[string]bool{"GracefulNodeShutdownBasedOnPodPriority": true},
},
},
{
name: "test banned failSwapOn",
config: &kubeletconfigv1beta1.KubeletConfiguration{
Expand Down