OCPCLOUD-3617: Update to Kubernetes 1.36 dependencies - #182
Conversation
|
@TheRealJon: This pull request references OCPCLOUD-3617 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "5.0.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThe project now targets Go 1.26.0 and Kubernetes 1.36.2, refreshes direct and indirect dependencies, updates build and envtest tooling, and adds a documented workflow with agent entry points for future Kubernetes and Go bumps. ChangesKubernetes and Go version bump
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
9de255b to
773518b
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@go.mod`:
- Line 119: Update the google.golang.org/grpc dependency in go.mod to v1.82.1 or
newer, then regenerate go.mod, go.sum, and vendored module metadata so all
dependency records consistently reference the upgraded version.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
c843f6a to
8cfd71c
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@Dockerfile`:
- Line 1: Add a USER directive to the final runtime stage based on
registry.ci.openshift.org/openshift/origin-v4.0:base, assigning a non-root UID
for container execution. Keep the builder stage unchanged and ensure the
directive applies to the final image.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
/lgtm Can unhold when CI's green. |
openshift-ci
Bot
added
the
do-not-merge/hold
openshift-ci
Bot
added
lgtm
|
Hey @TheRealJon could you please add a skill to this PR that follows this pattern closely for other MAPI providers but relevant for this component? (we can remove the bits in AGENTS.md that already cover some of this) Thanks! |
8cfd71c to
dd85bf8
Compare
|
@damdo I've updated with a new skill |
openshift-ci-robot
added
the
verified
|
@damdo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agents/skills/bump-k8s-go/SKILL.md:
- Around line 7-8: Restrict the allowed-tools declaration in the bump-k8s-go
skill to a least-privilege allowlist of specific read-only commands required by
the runbook. Remove the broad Bash(go *), Bash(git *), Bash(make *), Bash(gh *),
and Bash(curl *) wildcards, ensuring the configuration cannot perform repository
writes, GitHub mutations, arbitrary commands, or unrestricted network access.
In `@docs/development/bump-k8s-go.md`:
- Around line 189-203: Add an appropriate language identifier, preferably text,
to every untyped fenced code block in the documented image-tag examples,
including the related block referenced around lines 398-410. Ensure all six
opening fences satisfy markdownlint MD040 without changing their example
contents.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
|
/retest |
1 similar comment
|
/retest |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: damdo, nrb, theobarberbany The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
failing test is due to - https://redhat.atlassian.net/browse/OCPBUGS-90560 |
openshift-ci
Bot
added
the
needs-rebase
Update all Kubernetes dependencies from v0.35.1 to v0.36.2, controller-runtime from v0.23.3 to v0.24.1, and Go from 1.25 to 1.26. Update build images, envtest version, and Dockerfile for OCP 5.0. Add bump-k8s-go skill and runbook for future version bumps. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
dd85bf8 to
5441b88
Compare
openshift-ci-robot
removed
the
verified
openshift-ci
Bot
removed
lgtm
|
/test e2e-gcp-operator |
|
/retest |
|
/override ci/prow/regression-clusterinfra-gcp-ipi-mapi we are seeing this fail consistently for a while now - and its being investigated / fixed in #181 |
|
@theobarberbany: Overrode contexts on behalf of theobarberbany: ci/prow/regression-clusterinfra-gcp-ipi-mapi DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@TheRealJon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-ci
Bot
removed
the
do-not-merge/hold
openshift-ci-robot
added
the
verified
|
@damdo: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
6 participants
Summary
Key version changes
New files
docs/development/bump-k8s-go.md— Runbook for future k8s/Go version bumps.agents/skills/bump-k8s-go/SKILL.md— AI agent skill definition.claude/skills/bump-k8s-go— Symlink to skillTest plan
make buildpassesmake testpassesmake fmtproduces no changesmake vetpassesSummary by CodeRabbit
Documentation
setup-envtestversion.Chores