OCPBUGS-86869: Upgrades envtest Makefile target by raphaelvrosa · Pull Request #715 · openshift/ingress-node-firewall

raphaelvrosa · 2026-06-02T15:54:53Z

Sets it to use go install with 0.20.0 envtest version (compatible with go 1.24, and k8s.io/kubernetes v1.32.3).
Updates test Makefile targets to reflect changes in envtest
Other changes come from make test call that automates the updates of base CRD yamls.
Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.
Old kubebuilder envtest was deprecated - 🚨 Action Required: Ensure that you no longer use https://storage.googleapis.com/kubebuilder-tools kubernetes-sigs/kubebuilder#4082
Unblocks: OCPBUGS-78374: Updating ingress-node-firewall-daemon-container image to be consistent with ART for 4.20 #703

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it
Clone and run a make test locally.

- Description for the changelog

coderabbitai · 2026-06-02T15:55:01Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 3af0abb8-505e-47df-8e20-be0eacc5391f

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

openshift-ci-robot · 2026-06-02T15:56:10Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

expected the bug to target only the "4.21.z" version, but multiple target versions were set
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-86869 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Sets it to use go install with 0.20.4 envtest version.

Updates test Makefile targets to reflect changes in envtest

Other changes come from make test call that automates the updates of base CRD yamls.

Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

raphaelvrosa · 2026-06-02T15:57:51Z

/jira-refresh

openshift-ci-robot · 2026-06-02T15:59:17Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
expected Jira Issue OCPBUGS-86869 to depend on a bug targeting a version in 4.22.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Sets it to use go install with 0.20.4 envtest version.

Updates test Makefile targets to reflect changes in envtest

Other changes come from make test call that automates the updates of base CRD yamls.

Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly.

Unblocks: #703

- What this PR does and why is it needed

- Special notes for reviewers

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

raphaelvrosa · 2026-06-02T16:02:25Z

/jira-refresh

raphaelvrosa · 2026-06-05T08:50:40Z

@danwinship can you please take a look?

danwinship · 2026-06-09T13:39:17Z

/approve
can you squash the commits (and update the version number mentioned in the commit).

Why the confusion about 0.20.0 vs 0.20.4?

openshift-ci · 2026-06-09T13:41:04Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danwinship, raphaelvrosa

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [danwinship]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

- Sets it to use go install with 0.20.0 envtest version. - Updates test Makefile targets to reflect changes in envtest - Other changes come from `make test` call that automates the updates of base CRD yamls. - Updates failed test case: changed from TCP to UDP protocol, as it appears the test was not being executed properly. Signed-off-by: Raphael Rosa <raprosa@redhat.com>

raphaelvrosa · 2026-06-10T09:07:02Z

/approve can you squash the commits (and update the version number mentioned in the commit).

Why the confusion about 0.20.0 vs 0.20.4?

Yep, done.
Typo from an AI recommendation, 0.20.4 does not exist.

danwinship · 2026-06-10T11:35:09Z

/lgtm

raphaelvrosa · 2026-06-10T15:56:34Z

/retest-required

raphaelvrosa · 2026-06-10T16:03:26Z

/jira refresh

openshift-ci-robot · 2026-06-10T16:03:32Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

expected dependent Jira Issue OCPBUGS-77401 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is Closed (Obsolete) instead
expected dependent Jira Issue OCPBUGS-77401 to target a version in 4.22.0, but it targets "4.22" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

raphaelvrosa · 2026-06-10T16:06:41Z

/jira refresh

openshift-ci-robot · 2026-06-10T16:06:45Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

expected dependent Jira Issue OCPBUGS-79056 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2026-06-10T17:56:21Z

@raphaelvrosa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

raphaelvrosa · 2026-06-11T07:06:00Z

/jira refresh

openshift-ci-robot · 2026-06-11T07:06:05Z

@raphaelvrosa: This pull request references Jira Issue OCPBUGS-86869, which is invalid:

expected dependent Jira Issue OCPBUGS-79056 to target a version in 4.22.0, but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci Bot requested review from jcaamano and martinkennelly June 2, 2026 15:55

raphaelvrosa changed the title ~~Upgrades envtest Makefile target~~ OCPBUGS-86869: Upgrades envtest Makefile target Jun 2, 2026

openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 2, 2026

openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 2, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 9, 2026

raphaelvrosa force-pushed the release-4.21 branch from 3bdb678 to b599e7e Compare June 10, 2026 09:05

openshift-ci Bot assigned danwinship Jun 10, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 10, 2026

Conversation

raphaelvrosa commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jun 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

raphaelvrosa commented Jun 2, 2026

Uh oh!

openshift-ci-robot commented Jun 2, 2026

Uh oh!

raphaelvrosa commented Jun 2, 2026

Uh oh!

raphaelvrosa commented Jun 5, 2026

Uh oh!

danwinship commented Jun 9, 2026

Uh oh!

openshift-ci Bot commented Jun 9, 2026

Uh oh!

raphaelvrosa commented Jun 10, 2026

Uh oh!

danwinship commented Jun 10, 2026

Uh oh!

raphaelvrosa commented Jun 10, 2026

Uh oh!

raphaelvrosa commented Jun 10, 2026

Uh oh!

openshift-ci-robot commented Jun 10, 2026

Uh oh!

raphaelvrosa commented Jun 10, 2026

Uh oh!

openshift-ci-robot commented Jun 10, 2026

Uh oh!

openshift-ci Bot commented Jun 10, 2026

Uh oh!

raphaelvrosa commented Jun 11, 2026

Uh oh!

openshift-ci-robot commented Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

raphaelvrosa commented Jun 2, 2026 •

edited

Loading

coderabbitai Bot commented Jun 2, 2026 •

edited

Loading