OCPBUGS-87452: Updating ose-hypershift-container image to be consistent with ART for 5.0

[openshift-bot]

Updating ose-hypershift-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
hypershift.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

• Component owners are responsible for ensuring these alignment PRs merge with passing
  tests OR that necessary metadata changes are reported to the ART team
  in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
  introduced with a separate PR opened by the component team. Once the repository is aligned,
  this PR will be closed automatically.
• In particular, it could be that a job like verify-deps is complaining. In that case, please open
  a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
• Patch-manager or those with sufficient privileges within this repository may add
  any required labels to ensure the PR merges once tests are passing. In cases where ART config is
  canonical, downstream builds are already being built with these changes, and merging this PR
  only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
  a grace period for the component team to align their CI with ART's configuration before it becomes
  canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

Change behavior of future PRs:

• In case you just want to follow the base images that ART suggests, you can configure additional labels to be
  set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
  To do so, open a PR to set the auto_label attribute in the image configuration. Example
• You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out in the #forum-ocp-art Slack channel.

[openshift-bot]

Created by ART pipeline job run https://art-jenkins.apps.prod-stable-spoke1-dc-iad2.itup.redhat.com/job/aos-cd-builds/job/build%252Fsync-ci-images/216

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Please specify an area label

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

This PR updates base image tags across CI and container build configurations. The CI operator root image tag in .ci-operator.yaml is bumped from Go 1.25/OpenShift 4.23 to Go 1.26/OpenShift 5.0. The Dockerfile.control-plane builder stage and final runtime stage base images are similarly updated to use OpenShift 5.0 images and Go 1.26. Build steps, entrypoints, and operator labels remain unchanged.

🚥 Pre-merge checks | ✅ 11

✅ Passed checks (11 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PR only modifies CI configuration files (.ci-operator.yaml, Dockerfile.control-plane), not Ginkgo test code. Check is not applicable.
Test Structure And Quality	✅ Passed	No Ginkgo test code changes in PR; changes limited to CI configuration and Dockerfile base image references, making the test quality check not applicable.
Topology-Aware Scheduling Compatibility	✅ Passed	PR updates CI build configuration and base image tags only; no deployment manifests, operator code, or scheduling constraints are added or modified, so topology-aware scheduling check does not apply.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PR updates CI configuration only (.ci-operator.yaml, Dockerfile.control-plane); no new Ginkgo e2e tests are added, so the IPv6/disconnected network check does not apply.
No-Weak-Crypto	✅ Passed	PR updates base image versions for OpenShift 5.0 compatibility; no cryptographic code changes, weak crypto patterns, or custom crypto implementations introduced.
Container-Privileges	✅ Passed	PR updates CI configuration and Dockerfile base images only; no Kubernetes manifests, privileged containers, or privilege escalation settings are added or modified.
No-Sensitive-Data-In-Logs	✅ Passed	PR updates CI configuration and Dockerfile base images only; no logging code or sensitive data exposure detected in the changes.
Title check	✅ Passed	The title clearly references the main change: updating the ose-hypershift-container image to align with ART for OpenShift 5.0, which matches the file changes updating Go and OpenShift versions.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-bot
Once this PR has been reviewed and has the lgtm label, please assign muraee for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-87452, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Updating ose-hypershift-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
hypershift.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

• Component owners are responsible for ensuring these alignment PRs merge with passing
  tests OR that necessary metadata changes are reported to the ART team
  in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
  introduced with a separate PR opened by the component team. Once the repository is aligned,
  this PR will be closed automatically.
• In particular, it could be that a job like verify-deps is complaining. In that case, please open
  a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
• Patch-manager or those with sufficient privileges within this repository may add
  any required labels to ensure the PR merges once tests are passing. In cases where ART config is
  canonical, downstream builds are already being built with these changes, and merging this PR
  only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
  a grace period for the component team to align their CI with ART's configuration before it becomes
  canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

• In case you just want to follow the base images that ART suggests, you can configure additional labels to be
  set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
  To do so, open a PR to set the auto_label attribute in the image configuration. Example
• You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out in the #forum-ocp-art Slack channel.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@openshift-bot: This pull request references Jira Issue OCPBUGS-87452, which is valid.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Details

In response to this:

Updating ose-hypershift-container image to be consistent with ART for 5.0
TLDR:
Product builds by ART can be configured for different base and builder images than corresponding CI
builds. This automated PR requests a change to CI configuration to align with ART's configuration;
please take steps to merge it quickly or contact ART to coordinate changes.

The configuration in the following ART component metadata is driving this alignment request:
hypershift.yml.

Detail:

This repository is out of sync with the downstream product builds for this component. The CI
configuration for at least one image differs from ART's expected product configuration. This should
be addressed to ensure that the component's CI testing accurate reflects what customers will
experience.

Most of these PRs are opened as an ART-driven proposal to migrate base image or builder(s) to a
different version, usually prior to GA. The intent is to effect changes in both configurations
simultaneously without breaking either CI or ART builds, so usually ART builds are configured to
consider CI as canonical and attempt to match CI config until the PR merges to align both. ART may
also configure changes in GA releases with CI remaining canonical for a brief grace period to enable
CI to succeed and the alignment PR to merge. In either case, ART configuration will be made
canonical at some point (typically at branch-cut before GA or release dev-cut after GA), so it is
important to align CI configuration as soon as possible.

PRs are also triggered when CI configuration changes without ART coordination, for instance to
change the number of builder images or to use a different golang version. These changes should be
coordinated with ART; whether ART configuration is canonical or not, preferably it would be updated
first to enable the changes to occur simultaneously in both CI and ART at the same time. This also
gives ART a chance to validate the intended changes first. For instance, ART compiles most
components with the Golang version being used by the control plane for a given OpenShift release.
Exceptions to this convention (i.e. you believe your component must be compiled with a Golang
version independent from the control plane) must be granted by the OpenShift staff engineers and
communicated to the ART team.

Roles & Responsibilities:

• Component owners are responsible for ensuring these alignment PRs merge with passing
  tests OR that necessary metadata changes are reported to the ART team
  in #forum-ocp-art on Slack. If necessary, the changes required by this pull request can be
  introduced with a separate PR opened by the component team. Once the repository is aligned,
  this PR will be closed automatically.
• In particular, it could be that a job like verify-deps is complaining. In that case, please open
  a new PR with the dependency issues addressed (and base images bumped). ART-9595 for reference.
• Patch-manager or those with sufficient privileges within this repository may add
  any required labels to ensure the PR merges once tests are passing. In cases where ART config is
  canonical, downstream builds are already being built with these changes, and merging this PR
  only improves the fidelity of our CI. In cases where ART config is not canonical, this provides
  a grace period for the component team to align their CI with ART's configuration before it becomes
  canonical in product builds.

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image).
In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
 from_repository: true

Change behavior of future PRs:

• In case you just want to follow the base images that ART suggests, you can configure additional labels to be
  set up automatically. This means that such a PR would merge without human intervention (and awareness!) in the future.
  To do so, open a PR to set the auto_label attribute in the image configuration. Example
• You can set a commit prefix, like UPSTREAM: <carry>: . An example.

If you have any questions about this pull request, please reach out in the #forum-ocp-art Slack channel.

Summary by CodeRabbit

• Chores
• Updated CI build environment and container images to use Go 1.26 and OpenShift 5.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 41.43%. Comparing base (a101e66) to head (9c843bf).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #8694   +/-   ##
=======================================
  Coverage   41.43%   41.43%           
=======================================
  Files         756      756           
  Lines       93648    93648           
=======================================
  Hits        38803    38803           
  Misses      52124    52124           
  Partials     2721     2721           

Flag	Coverage Δ
cmd-support	34.87% <ø> (ø)
cpo-hostedcontrolplane	43.50% <ø> (ø)
cpo-other	42.75% <ø> (ø)
hypershift-operator	51.57% <ø> (ø)
other	31.64% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[coderabbitai]

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)

Dockerfile.control-plane (1)

11-32: ⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Add non-root execution and a health check in the runtime image.

The final image has no USER and no HEALTHCHECK, so it runs as root by default and misses runtime liveness signaling. Please add an explicit non-root user and a health check in this stage.

As per coding guidelines, **/{Dockerfile,Containerfile}* requires: “USER non-root; never run as root” and “HEALTHCHECK defined”.

Suggested patch

 FROM registry.ci.openshift.org/ocp/5.0:base-rhel9
 COPY --from=builder /hypershift/bin/control-plane-operator /usr/bin/control-plane-operator
 COPY --from=builder /hypershift/bin/control-plane-pki-operator /usr/bin/control-plane-pki-operator
 
+USER 1001
+HEALTHCHECK --interval=30s --timeout=5s --start-period=20s --retries=3 \
+  CMD ["/usr/bin/control-plane-operator", "healthz"] || exit 1
+
 ENTRYPOINT /usr/bin/control-plane-operator

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@Dockerfile.control-plane` around lines 11 - 32, The final stage lacks a
non-root user and a HEALTHCHECK: create or switch to a non-root user and set
USER to that account, ensure the runtime binaries
(/usr/bin/control-plane-operator and /usr/bin/control-plane-pki-operator) are
owned/read-executable by that user (adjust ownership/permissions after COPY),
and add a HEALTHCHECK (for example a CMD-SHELL that verifies the main process is
alive such as pgrep -f /usr/bin/control-plane-operator or an HTTP/health
endpoint if available) so the container does not run as root and provides
liveness signaling; keep ENTRYPOINT /usr/bin/control-plane-operator unchanged.

Sources: Coding guidelines, Linters/SAST tools

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Outside diff comments:
In `@Dockerfile.control-plane`:
- Around line 11-32: The final stage lacks a non-root user and a HEALTHCHECK:
create or switch to a non-root user and set USER to that account, ensure the
runtime binaries (/usr/bin/control-plane-operator and
/usr/bin/control-plane-pki-operator) are owned/read-executable by that user
(adjust ownership/permissions after COPY), and add a HEALTHCHECK (for example a
CMD-SHELL that verifies the main process is alive such as pgrep -f
/usr/bin/control-plane-operator or an HTTP/health endpoint if available) so the
container does not run as root and provides liveness signaling; keep ENTRYPOINT
/usr/bin/control-plane-operator unchanged.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8320324f-44cc-4dc6-bb88-81d41f046868

📥 Commits

Reviewing files that changed from the base of the PR and between a101e66 and 9c843bf.

📒 Files selected for processing (2)

• .ci-operator.yaml
• Dockerfile.control-plane

[openshift-ci]

@openshift-bot: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[hypershift-jira-solve-ci]

I have all the evidence needed. The root cause is clear from the logs.

Test Failure Analysis Complete

Job Information

• Prow Job: gitlint / Gitlint (GitHub Actions workflow gitlint-reusable.yaml)
• Build ID: GitHub Actions run 27088613675 / job 79947857319
• PR: #8694 — OCPBUGS-87452: Updating ose-hypershift-container image to be consistent with ART for 5.0
• Commit: 9c843bff04206b15a048d0f1c1d511814f2ae493
• Author: AOS Automation Release Team

Test Failure Analysis

Error

1: CT1 Title does not follow ConventionalCommits.org format 'type(optional-scope): description': "Updating ose-hypershift-container image to be consistent with ART for 5.0"
2: B4 Second line is not empty: "Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/af322abdd1a4d7d0161a69a16369a0ab1748515a/images/hypershift.yml"

Summary

The gitlint check failed because the commit message authored by the AOS Automation Release Team does not conform to the repository's Conventional Commits requirement. The commit has two violations: (1) the title line lacks the required type(optional-scope): description format (e.g., chore:, fix:, build:), and (2) the commit body starts immediately on the second line instead of having a mandatory blank line separating the title from the body. This is an automated ART (Art Release Team) consistency PR where the bot's commit message template does not follow the hypershift repo's .gitlint rules.

Root Cause

The AOS Automation Release Team bot creates commits with the message format:

Updating ose-hypershift-container image to be consistent with ART for 5.0
Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/.../images/hypershift.yml

The hypershift repository enforces Conventional Commits via gitlint (configured in .gitlint), which requires:

1. CT1 — Conventional Commit title: The title must match type(optional-scope): description where type is one of: fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build. The bot's title "Updating ose-hypershift-container image..." has no type prefix.

2. B4 — Blank second line: The Conventional Commits / git standard requires a blank line between the title and body. The bot's message puts the "Reconciling with..." line immediately on line 2 with no blank separator.

This is a systemic issue with the ART automation bot's commit message template not being updated to match the hypershift repo's linting rules. The bot generates the same non-conforming format for all ART consistency PRs.

Recommendations

1. Immediate fix (for this PR): Amend the commit message to conform to Conventional Commits format. For example:

   chore: update ose-hypershift-container image for ART consistency (5.0)
   
   Reconciling with https://github.com/openshift-eng/ocp-build-data/tree/af322abdd1a4d7d0161a69a16369a0ab1748515a/images/hypershift.yml
   

   Note the chore: prefix and the blank line between title and body.

2. Long-term fix: File a bug against the ART automation tooling (openshift-eng/ocp-build-data or the ART bot configuration) to update the commit message template for repos that enforce Conventional Commits. The template should use chore: or build: as the type prefix and include a blank line before the body.

3. Alternative: Add a .gitlint ignore rule for commits from the AOS Automation Release Team bot, though this is less desirable as it weakens the linting for all bot commits.

Evidence

Evidence	Detail
Gitlint rule CT1 violation	Title "Updating ose-hypershift-container image to be consistent with ART for 5.0" missing type: prefix
Gitlint rule B4 violation	No blank line between title and body; line 2 is "Reconciling with https://..."
Allowed types (.gitlint)	fix, feat, chore, docs, style, refactor, perf, test, revert, ci, build
Title max length	120 chars (not violated — title is 74 chars)
Commit author	AOS Automation Release Team (automated bot)
Commit SHA	9c843bff04206b15a048d0f1c1d511814f2ae493
Exit code	make run-gitlint exited with code 2 (2 violations found)
Workflow file	.github/workflows/gitlint-reusable.yaml invokes make run-gitlint
Config file	.gitlint enables contrib-title-conventional-commits

---

[openshift-bot]

ART wants to connect issue OCPBUGS-87706 to this PR, but found it is currently hooked up to ['OCPBUGS-87452']. Please consult with #forum-ocp-art if it is not clear what there is to do.