OCPBUGS-80948: update velero replace to track oadp-1.5 branch#228
OCPBUGS-80948: update velero replace to track oadp-1.5 branch#228jparrill wants to merge 1 commit into
Conversation
|
@jparrill: This pull request references Jira Issue OCPBUGS-80948, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
c716e8e to
2b6eb1c
Compare
2b6eb1c to
e9f691b
Compare
24265ba to
1baf118
Compare
|
Please @kaovilai do you mind review the oadp version set in the Makefile vs the ocp release assigned? |
4fd58d9 to
d3d0e90
Compare
d3d0e90 to
ff59f86
Compare
ff59f86 to
a078b1b
Compare
|
/lgtm Note Responses generated with Claude CI passing (build, unit, security, verify all green). go.mod replace directive verified — tracks latest commit on |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jparrill, kaovilai, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
human here: lgtm :) |
|
/jira refresh |
|
@kaovilai: This pull request references Jira Issue OCPBUGS-80948, which is invalid:
Comment DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Humm I need to see which image is the good one for the builders. |
- Update velero replace to latest oadp-1.5 commit (e8ffd8d87b42, 2026-05-01) - Align Go file fallback defaults from "main" to "release-4.21" to match Makefile - Change dependency test to warn-only (t.Log) instead of failing (t.Error), consistent with main branch behavior Fixes: OCPBUGS-80948 Ref: https://redhat.atlassian.net/browse/OCPBUGS-80948 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Juan Manuel Parrilla Madrid <jparrill@redhat.com>
a078b1b to
3a42f32
Compare
|
New changes are detected. LGTM label has been removed. |
|
@kaovilai @ToniSegura The Konflux pipeline is failing with an auth error when pulling the builder image: Two questions:
Note: I also fixed the |
|
I thought @weshayutin wanted these konflux ci gone favoring prow image building |
is correct because 1.25 is minimum go supported which we are using for any builds that do not require 1.26 |
probably. I do not have access to konflux pipelines tenants/secrets stuff for this repo (or any other repo, so not familiar). I will have to defer unless you can tell me what to do. |
|
@jparrill: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it
Updates the
go.modreplace directive for Velero from a stale pseudo-version to the latest commit on theoadp-1.5branch of openshift/velero.Before:
After:
This fixes two problems:
v2alpha1APIs the plugin depends on.This is the oadp-1.5 counterpart of #224 (which fixed main).
Which issue(s) this PR fixes
Fixes https://redhat.atlassian.net/browse/OCPBUGS-80948
Checklist
🤖 Generated with Claude Code