chore(config): migrate Renovate config#207
Conversation
red-hat-konflux
Bot
added
area/ci-tooling
ok-to-test
WalkthroughRenovate configuration file updated with reformatted array structures and revised dependency matching strategy, replacing matchPackagePrefixes with matchPackageNames using negated patterns for exclusion logic in Kubernetes-related dependency groups. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
Hi @red-hat-konflux[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
renovate.json (1)
27-30: Verify negation-onlymatchPackageNamesbehavior in this Renovate rule.This may work, but negation-only match lists can be ambiguous across matcher semantics. To make intent explicit and avoid silent non-matching, add a catch-all include before exclusions.
Proposed adjustment
"matchPackageNames": [ + "*", "!k8s.io/{/,}**", "!sigs.k8s.io/{/,}**" ]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@renovate.json` around lines 27 - 30, The current Renovate rule's matchPackageNames list contains only negations which can be ambiguous; update the matchPackageNames array (the matchPackageNames symbol in the Renovate rule) to include an explicit catch-all include (e.g., "*" or "**") as the first entry, followed by the existing negation entries, so the intent is explicit and the exclusions are applied reliably.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@renovate.json`:
- Around line 27-30: The current Renovate rule's matchPackageNames list contains
only negations which can be ambiguous; update the matchPackageNames array (the
matchPackageNames symbol in the Renovate rule) to include an explicit catch-all
include (e.g., "*" or "**") as the first entry, followed by the existing
negation entries, so the intent is explicit and the exclusions are applied
reliably.
|
@red-hat-konflux[bot]: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bryan-cox, red-hat-konflux[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
1 participant
The Renovate config in this repository needs migrating. Typically this is because one or more configuration options you are using have been renamed.
You don't need to merge this PR right away, because Renovate will continue to migrate these fields internally each time it runs. But later some of these fields may be fully deprecated and the migrations removed. So it's a good idea to merge this migration PR soon.
🔕 Ignore: Close this PR and you won't be reminded about config migration again, but one day your current config may no longer be valid.
❓ Got questions? Does something look wrong to you? Please don't hesitate to request help here.
To execute skipped test pipelines write comment
/ok-to-test.Documentation
Find out how to configure dependency updates in MintMaker documentation or see all available configuration options in Renovate documentation.