CMP-4638: central TLS profile consistency

[parametalol]

Heavily influenced by ComplianceAsCode/compliance-operator#1373.

Dependencies bump is also in a separate #1058.

[openshift-ci-robot]

@parametalol: This pull request references CMP-4638 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Heavily influenced by ComplianceAsCode/compliance-operator#1373.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @parametalol. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[yuumasato]

/ok-to-test

[abushkin-redhat]

/retest-required

[abushkin-redhat]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-bundle-aws
/test e2e-bundle-aws-upgrade
/test e2e-aws

[openshift-ci]

@parametalol: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-aws	9046093	link	true	/test e2e-aws
ci/prow/e2e-bundle-aws	9046093	link	false	/test e2e-bundle-aws
ci/prow/e2e-bundle-aws-upgrade	9046093	link	false	/test e2e-bundle-aws-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Vincent056]

The bundle CSV was not regenerated after adding config.openshift.io/apiservers get,list,watch to config/rbac/operator_clusterrole.yaml. bundle/manifests/file-integrity-operator.clusterserviceversion.yaml has no config.openshift.io rule, and bundle.Dockerfile copies bundle/manifests verbatim, so ci-index-file-integrity-operator-bundle / e2e-bundle-aws* would install the operator without the permission.

I reproduced what that does on a 4.21 cluster by removing the apiservers rule from the ClusterRole and restarting the pod:

"Could not fetch APIServer TLS profile, using defaults" ... apiservers.config.openshift.io "cluster" is forbidden
"Failed to watch" reflector ... failed to list *v1.APIServer: apiservers.config.openshift.io is forbidden   (repeats)
"Could not wait for Cache to sync" controller="tlssecurityprofilewatcher" ... timed out waiting for cache to be synced
"Manager exited non-zero" error="failed to wait for tlssecurityprofilewatcher caches to sync ..."

The container exits 1 after the 2 minute cache-sync timeout and crash-loops. The "using defaults" fallback in fetchClusterTLSSettings does not help because the watcher registered in makeSecurityProfileWatcher is fatal on cache-sync failure, so the RBAC is a hard runtime requirement.

Please run make bundle and commit bundle/manifests, then confirm e2e-bundle-aws is green (it has not run yet because of the Go 1.26 build failure). Optionally consider whether the watcher should degrade to "no change detection" instead of taking the operator down when the permission is missing (e.g. during an upgrade where the CSV RBAC lands late); CO made the same fatal choice, so at minimum it should be documented.

[openshift-ci]

New changes are detected. LGTM label has been removed.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: parametalol
Once this PR has been reviewed and has the lgtm label, please ask for approval from abushkin-redhat. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[yuumasato]

/ok-to-test

[red-hat-konflux-kflux-prd-rh02]

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.

[yuumasato]

Not sure if the prow tests are running or not, it has been 2 days since last change. Results should have been reported by now.
/retest

[red-hat-konflux-kflux-prd-rh02]

All PipelineRuns for this commit have already succeeded. Use /retest <pipeline-name> to re-run a specific pipeline or /test to re-run all pipelines.