Skip to content

OCPBUGS-97920: allow specific actions for AWS EFS CredentialsRequest #578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dobsonj wants to merge 1 commit into
base: main
Choose a base branch
from
+13 −2
Open

OCPBUGS-97920: allow specific actions for AWS EFS CredentialsRequest #578

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion assets/overlays/aws-efs/base/credentials.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,13 @@ spec:
statementEntries:
- effect: Allow
action:
- elasticfilesystem:*
# https://github.com/openshift/aws-efs-csi-driver/blob/master/docs/iam-policy-example.json
- elasticfilesystem:DescribeAccessPoints
- elasticfilesystem:DescribeFileSystems
- elasticfilesystem:DescribeMountTargets
- elasticfilesystem:CreateAccessPoint
- elasticfilesystem:DeleteAccessPoint
- elasticfilesystem:TagResource
Comment thread
dobsonj marked this conversation as resolved.
- ec2:DescribeAvailabilityZones # for one-zone volumes
resource: "*"

@rhrmo rhrmo Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see that the policy example restricts the resources of create/delete access point and tag resource with

"Condition": {
        "StringLike": {
          "aws:RequestTag/efs.csi.aws.com/cluster": "true"
        }

should we also use this for these actions?

@rhrmo rhrmo Jul 23, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see it was also coderabbits comment and it is resolved, I wonder, can users set their own resource tags and that is why it would now work? Or what is the reason? 🤔

# STS fields will be set by the operator
7 changes: 6 additions & 1 deletion assets/overlays/aws-efs/generated/standalone/credentials.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,12 @@ spec:
kind: AWSProviderSpec
statementEntries:
- action:
- elasticfilesystem:*
- elasticfilesystem:DescribeAccessPoints
- elasticfilesystem:DescribeFileSystems
- elasticfilesystem:DescribeMountTargets
- elasticfilesystem:CreateAccessPoint
- elasticfilesystem:DeleteAccessPoint
- elasticfilesystem:TagResource
- ec2:DescribeAvailabilityZones
effect: Allow
resource: '*'
Expand Down