OCPBUGS-102145: Replace golang.org/x/net with sustaining fork v0.35.0-sec.4

[katekeiroz-dev]

Summary

This PR addresses CVE-2026-33814 (GO-2026-4918) by replacing golang.org/x/net with the OpenShift sustaining fork that backports the HTTP/2 SETTINGS_MAX_FRAME_SIZE DoS fix. A direct bump to upstream v0.53.0 is not used because that module requires Go 1.25.0, which would change the go directive on release-4.12.

Changes

• Added replace golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.4 to go.mod
• Ran go mod tidy and go mod vendor
• Left go 1.18 unchanged

Commands Used

go mod edit -replace golang.org/x/net=github.com/openshift-sustaining/net@v0.35.0-sec.4
go mod tidy
go mod vendor

Why Replace Directive?

Upstream golang.org/x/net v0.53.0 requires Go 1.25.0, but release-4.12 must stay on Go 1.18. The sustaining fork v0.35.0-sec.4 backports the HTTP/2 SETTINGS validation fix onto a Go 1.18-compatible module line.

This matches the approach already used for the same CVE on MAPO 4.15 (openshift/machine-api-provider-openstack#182).

CVE Details

CVE-2026-33814: Go HTTP/2 denial of service via malformed SETTINGS_MAX_FRAME_SIZE frame

• Severity: Important (CVSS 7.5)
• Go vulnerability: GO-2026-4918
• Affected: golang.org/x/net before v0.53.0
• Impact: Transport can enter an infinite loop of writing CONTINUATION frames if it receives SETTINGS_MAX_FRAME_SIZE with value 0
• Current version on this branch: v0.18.0

The stdlib net/http vector of this CVE is handled separately via ART builder-image rebuilds (openshift-golang-builder-container).

Test Plan

• go directive unchanged (go 1.18)
• Vendor includes s.Valid() in http2.processSettingsNoWrite (rejects invalid MAX_FRAME_SIZE)
• go build . succeeds with Go 1.18.10
• CI unit tests pass
• QE / security verification

Related

• Jira: OCPBUGS-102145
• Go Vuln DB: GO-2026-4918
• Sustaining fork: https://github.com/openshift-sustaining/net/tree/v0.35.0-sec.4
• Sibling PRs: 4.14 and 4.13 in this repo

Made with Cursor

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 28683662-2310-49b0-89a0-8febd4701b61

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci-robot]

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-102145, which is invalid:

• expected dependent Jira Issue OCPBUGS-102333 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ASSIGNED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

This PR addresses CVE-2026-33814 (GO-2026-4918) by replacing golang.org/x/net with the OpenShift sustaining fork that backports the HTTP/2 SETTINGS_MAX_FRAME_SIZE DoS fix. A direct bump to upstream v0.53.0 is not used because that module requires Go 1.25.0, which would change the go directive on release-4.12.

Changes

• Added replace golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.4 to go.mod
• Ran go mod tidy and go mod vendor
• Left go 1.18 unchanged

Commands Used

go mod edit -replace golang.org/x/net=github.com/openshift-sustaining/net@v0.35.0-sec.4
go mod tidy
go mod vendor

Why Replace Directive?

Upstream golang.org/x/net v0.53.0 requires Go 1.25.0, but release-4.12 must stay on Go 1.18. The sustaining fork v0.35.0-sec.4 backports the HTTP/2 SETTINGS validation fix onto a Go 1.18-compatible module line.

This matches the approach already used for the same CVE on MAPO 4.15 (openshift/machine-api-provider-openstack#182).

CVE Details

CVE-2026-33814: Go HTTP/2 denial of service via malformed SETTINGS_MAX_FRAME_SIZE frame

• Severity: Important (CVSS 7.5)
• Go vulnerability: GO-2026-4918
• Affected: golang.org/x/net before v0.53.0
• Impact: Transport can enter an infinite loop of writing CONTINUATION frames if it receives SETTINGS_MAX_FRAME_SIZE with value 0
• Current version on this branch: v0.18.0

The stdlib net/http vector of this CVE is handled separately via ART builder-image rebuilds (openshift-golang-builder-container).

Test Plan

• go directive unchanged (go 1.18)
• Vendor includes s.Valid() in http2.processSettingsNoWrite (rejects invalid MAX_FRAME_SIZE)
• go build . succeeds with Go 1.18.10
• CI unit tests pass
• QE / security verification

Related

• Jira: OCPBUGS-102145
• Go Vuln DB: GO-2026-4918
• Sustaining fork: https://github.com/openshift-sustaining/net/tree/v0.35.0-sec.4
• Sibling PRs: 4.14 and 4.13 in this repo

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[katekeiroz-dev]

/ok-to-test

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign fedosin for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ocp-sustaining-admins]

/retest-required

[openshift-ci]

@katekeiroz-dev: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/images	c0c754e	link	true	/test images
ci/prow/unit	c0c754e	link	true	/test unit

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.