test(e2e): add test-e2e-from-ci-bundle target to Makefile - #3378
test(e2e): add test-e2e-from-ci-bundle target to Makefile#3378vparfonov wants to merge 1 commit into
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe PR adds a Makefile target and Bash runner for CI E2E tests. It configures namespace labels and test options. Container security checks now skip unavailable mount paths. ChangesCI E2E execution
Estimated code review effort: 2 (Simple) | ~15 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
PR Summary by QodoAdd CI-bundle e2e test Make target with CI-friendly runner flags
AI Description
Diagram
High-Level Assessment
Files changed (4)
|
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: vparfonov The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/test-e2e-from-ci-bundle.sh`:
- Line 1: Update the executable permission metadata for
hack/test-e2e-from-ci-bundle.sh from 100644 to 100755 so the Makefile target can
invoke it directly in CI.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 9813f581-ce36-4793-b830-ee14b65f7461
📒 Files selected for processing (2)
Makefilehack/test-e2e-from-ci-bundle.sh
Code Review by Qodo
Context used✅ Compliance rules (platform):
9 rules 1.
|
![qodo-for-rh-openshift[bot]](https://avatars.githubusercontent.com/u/792337?s=60&v=4){kind=small}
|
/test e2e-using-bundle |
|
Unsupported PR languages |
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
/test e2e-using-bundle |
|
Unsupported PR languages |
|
/test e2e-using-bundle |
|
Unsupported PR languages |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
Code review by qodo was updated up to the latest commit 6d120f9 |
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/test-e2e-from-ci-bundle.sh`:
- Around line 3-5: Make the namespace-label setup command fail the script when
`oc label ns/openshift-logging` cannot complete, before the `go test` invocation
runs. Update the shell failure handling near the label command in
`hack/test-e2e-from-ci-bundle.sh` while preserving the existing label and test
commands.
In `@test/e2e/collection/security/container_security_test.go`:
- Around line 39-40: Update the security test assertions around touchFile to
first verify that the expected mount path exists, then validate the touch
command failure while allowing the environment-specific read-only filesystem
error. Remove “No such file or directory” from the touch error regexp so a
missing mount cannot satisfy the test.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: c45f4dd2-1829-41b7-9a7a-93a440a4ec1d
📒 Files selected for processing (4)
Makefilehack/test-e2e-from-ci-bundle.shtest/e2e/collection/security/container_security_test.gotest/e2e/input_selection/input_selection_test.go
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@hack/test-e2e-from-ci-bundle.sh`:
- Around line 8-13: Synchronize the namespace used by the script’s
CLUSTER_LOGGING_OPERATOR_NAMESPACE override with the E2E setup in
container_security_test.go: thread that configured namespace into the test
instead of hard-coding constants.OpenshiftNS, or remove the script override.
Ensure labeling and security checks always target the same namespace.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 1179a515-ea4d-42ca-92fe-002908dd853c
📒 Files selected for processing (4)
Makefilehack/test-e2e-from-ci-bundle.shtest/e2e/collection/security/container_security_test.gotest/e2e/input_selection/input_selection_test.go
|
/retest-required |
|
/test e2e-target |
|
PR-Agent: could not find a component named |
Add Make target and script to run Go e2e tests when the operator is deployed via OLM bundle in CI. NOTE: - runs test packages sequentially to avoid resource collisions - skips FlowControl tests (as in regular e2e test) Signed-off-by: Vitalii Parfonov <vparfono@redhat.com>
|
/test e2e-target |
|
PR-Agent: could not find a component named |
|
@vparfonov: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Description
/cc @Clee2691
/assign @jcantrill
Links
Summary by CodeRabbit
Tests
Chores