Skip to content

OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support - #508

Open
patrickdillon wants to merge 2 commits into
openshift:release-4.22from
patrickdillon:gcd-422
Open

OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support#508
patrickdillon wants to merge 2 commits into
openshift:release-4.22from
patrickdillon:gcd-422

Conversation

@patrickdillon

Copy link
Copy Markdown
Contributor

Manual cherrypicks of #502 and #493 to backport GCD support to 4.22

Updates the required permissions needed for GCP. Currently these
are only used for GCD.
On GCP, we should mount the bound sa token volume, similarly to how
it is done on Azure. Typically the volume is mounted by the CCO
webhook, but that pattern is problematic if the CCM needs the
projected credentials to schedule the CCO to run it's webhook, in
which case we hit a deadlock. We can avoid this entirely by simply
always mounting.

This doesn't occur in most installs because the CCM is authenticated
by a VM attached to the service account, but GCD uses a projected
credential and we want to move that direction for all installs
because you can dynamically upgrade permissions.
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 67c63414-50b2-491e-b179-aa7cf627daec

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from damdo and theobarberbany August 26, 2026 16:52
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign theobarberbany for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@patrickdillon

Copy link
Copy Markdown
Contributor Author

/jira cherrypick OCPBUGS-112142

@openshift-ci-robot

Copy link
Copy Markdown

@patrickdillon: Jira Issue OCPBUGS-112142 has been cloned as Jira Issue OCPBUGS-114394. Will retitle bug to link to clone.
/retitle OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support

Details

In response to this:

/jira cherrypick OCPBUGS-112142

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot changed the title [release-4.22] GCP Alternate Universe Domain Support OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support Aug 26, 2026
@openshift-ci-robot openshift-ci-robot added jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Aug 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@patrickdillon: This pull request references Jira Issue OCPBUGS-114394, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-112142 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Jira Issue OCPBUGS-112142 targets the "5.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherrypicks of #502 and #493 to backport GCD support to 4.22

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@patrickdillon: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants