OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support - #508
OCPBUGS-114394: [release-4.22] GCP Alternate Universe Domain Support#508patrickdillon wants to merge 2 commits into
Conversation
Updates the required permissions needed for GCP. Currently these are only used for GCD.
On GCP, we should mount the bound sa token volume, similarly to how it is done on Azure. Typically the volume is mounted by the CCO webhook, but that pattern is problematic if the CCM needs the projected credentials to schedule the CCO to run it's webhook, in which case we hit a deadlock. We can avoid this entirely by simply always mounting. This doesn't occur in most installs because the CCM is authenticated by a VM attached to the service account, but GCD uses a projected credential and we want to move that direction for all installs because you can dynamically upgrade permissions.
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
/jira cherrypick OCPBUGS-112142 |
|
@patrickdillon: Jira Issue OCPBUGS-112142 has been cloned as Jira Issue OCPBUGS-114394. Will retitle bug to link to clone. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: This pull request references Jira Issue OCPBUGS-114394, which is valid. The bug has been moved to the POST state. 7 validation(s) were run on this bug
The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@patrickdillon: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Manual cherrypicks of #502 and #493 to backport GCD support to 4.22