[release-4.21] 🐛 NO-JIRA: UPSTREAM: <carry>: openshift: fix unit tests by replacing deprecated kubebuilder-tools GCS download

[stefanonardo]

Summary

• The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job to fail before any tests run (curl exit code 22).
• Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses setup-envtest (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
• Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.
• Fix TestGetManagerNamespace in util/system: when running inside a Kubernetes pod (as Prow does), the serviceaccount namespace file exists and the function returns the pod namespace instead of falling through to the env var / default. Promote inClusterNamespacePath from const to var so tests can override it.
• Fix TestROSARoleConfigReconcileExist in exp/controllers: the test called Reconcile() once and waited for status to appear, but the status subresource is separate in Kubernetes so a single call isn't guaranteed to fully converge. Port the fix from upstream commit 2002948f5 — move Reconcile() inside Eventually with WithPolling(500ms) so it retries until the status reaches the expected state.

Test plan

• Prow unit test job passes on this PR

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
• Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
• Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

• Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 9aebdf56-41f0-4d30-9028-8e8b20b2debc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign radekmanak for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@stefanonardo: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

• The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
• Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
• Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

• Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

Summary

• The storage.googleapis.com/kubebuilder-tools GCS bucket now returns HTTP 403, causing the Prow unit test job (pull-ci-openshift-cluster-api-provider-aws-release-4.21-unit) to fail before any tests run (curl exit code 22).
• Replace openshift/unit-tests.sh with the approach already used on main: call make test-verbose, which uses the setup-envtest tool (already wired in the release-4.21 Makefile) to fetch test binaries via the GitHub-hosted envtest-releases.yaml index.
• Delete openshift/fetch_ext_bins.sh — it only existed to serve the broken GCS download path.

Test plan

• Prow unit test job passes on this PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[stefanonardo]

/jira refresh

[openshift-ci-robot]

@stefanonardo: This pull request explicitly references no jira issue.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

@stefanonardo: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.