OCPBUGS-103524: Replace golang.org/x/net with sustaining fork for CVE-2026-33814 in 4.18 - #135
Conversation
…CVE-2026-33814 This PR uses the OpenShift sustaining fork of golang.org/x/net that backports the CVE-2026-33814 fix while maintaining Go 1.22 compatibility. The upstream fix (v0.53.0) requires Go 1.25.0+, which is incompatible with release-4.18. There is no Go 1.22-specific sustaining tag; v0.35.0-sec.3 is the Go 1.18-compatible backport of the same fix. Sustaining fork: github.com/openshift-sustaining/net@v0.35.0-sec.3 Related: OCPBUGS-103524 Co-authored-by: Cursor <cursoragent@cursor.com>
|
@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-103524, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@katekeiroz-dev: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
This PR addresses CVE-2026-33814 by replacing
golang.org/x/netwith the OpenShift sustaining fork that contains the security fix. The upstream patched version requires a Go upgrade that release-4.18 cannot take.Changes
golang.org/x/net => github.com/openshift-sustaining/net v0.35.0-sec.3go.modandgo.sumWhy Replace Directive?
golang.org/x/netv0.53.0 requires Go 1.25.0+, but release-4.18 must keep Go 1.22.5. There is no Go 1.22-specific sustaining tag.v0.35.0-sec.3backports the CVE-2026-33814Setting.Valid()check on Go 1.18, which is compatible with 1.22.CVE Details
CVE-2026-33814 / GO-2026-4918: HTTP/2 client infinite loop DoS when a peer sends
SETTINGS_MAX_FRAME_SIZE=0.Upstream References
<carry>Test Plan
go 1.22.5)processSettingsNoWritecallss.Valid()Related
Made with Cursor