OCPBUGS-93617: Bump golang.org/x/crypto to v0.52.0 - #413
Conversation
Signed-off-by: Venkata Charan Sunku <vsunku@redhat.com>
|
@sunku5494: This pull request references Jira Issue OCPBUGS-93617, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
WalkthroughThe pull request updates the indirect ChangesDependency update
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related issues
Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: sunku5494 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@sunku5494: This pull request references Jira Issue OCPBUGS-93617, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
go.mod (1)
172-172: 🔒 Security & Privacy | 🔵 TrivialAdd release supply-chain controls.
golang.org/x/crypto v0.52.0is pinned and has matchinggo.sumhashes. The release workflow has no SBOM, provenance-attestation, or Sigstore/cosign signing steps. Add these controls and rungovulncheck ./...to check reachablegolang.org/x/crypto/sshsymbols.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@go.mod` at line 172, Add release-workflow steps for SBOM generation, provenance attestation, and Sigstore/cosign artifact signing, ensuring they run for the built release artifacts. Run govulncheck ./... and address any reachable vulnerabilities involving golang.org/x/crypto/ssh while preserving the pinned dependency and matching go.sum hashes.Source: Path instructions
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@go.mod`:
- Line 172: Add release-workflow steps for SBOM generation, provenance
attestation, and Sigstore/cosign artifact signing, ensuring they run for the
built release artifacts. Run govulncheck ./... and address any reachable
vulnerabilities involving golang.org/x/crypto/ssh while preserving the pinned
dependency and matching go.sum hashes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 8b791cf4-fefb-435f-814c-363f27fa24a5
⛔ Files ignored due to path filters (8)
go.sumis excluded by!**/*.sumvendor/golang.org/x/crypto/ssh/certs.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/crypto/ssh/channel.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/crypto/ssh/cipher.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/crypto/ssh/keys.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/crypto/ssh/mux.gois excluded by!**/vendor/**,!vendor/**vendor/golang.org/x/crypto/ssh/server.gois excluded by!**/vendor/**,!vendor/**vendor/modules.txtis excluded by!**/vendor/**,!vendor/**
📒 Files selected for processing (1)
go.mod
|
/test e2e-openstack |
|
@sunku5494: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What this PR does / why we need it:
Updates crypto package to v0.52.0 to pull in recent security patches, specifically targeting CVE-2026-39835. While our codebase does not currently use any of the vulnerable symbols identified in the CVE, this update keeps main aligned with the latest secure package version as a proactive measure.
Which issue this PR fixes(if applicable):
fixes #
This PR fixes CVE-2026-39835 and many other CVEs reported for crypto pkg
Special notes for reviewers:
Release note:
Summary by CodeRabbit