Skip to content

Bump golang.org/x/net to v0.53.0 and refresh vendor for CVE-2026-33814 - #163

Open
atewari-rh wants to merge 1 commit into
openshift:release-4.22from
atewari-rh:local_release-4.22
Open

Bump golang.org/x/net to v0.53.0 and refresh vendor for CVE-2026-33814#163
atewari-rh wants to merge 1 commit into
openshift:release-4.22from
atewari-rh:local_release-4.22

Conversation

@atewari-rh

Copy link
Copy Markdown

Bump golang.org/x/net to v0.53.0 for CVE-2026-33814 (GO-2026-4918)

Summary

Remediates CVE-2026-33814 / GO-2026-4918 by upgrading golang.org/x/net from v0.48.0 to v0.53.0 and refreshing vendored dependencies on OpenShift 4.22 (release-4.22).

The vulnerability is an HTTP/2 client DoS: when a peer sends SETTINGS_MAX_FRAME_SIZE = 0, the transport can enter an infinite loop. The fix validates all SETTINGS via Setting.Valid() before applying them (fixed upstream in golang.org/x/net ≥ v0.53.0 and Go stdlib ≥ 1.25.10).

Changes

  • Bump golang.org/x/net v0.48.0v0.53.0 in the root module and tests/e2e
  • Refresh vendor/ for both modules so shipped binaries use the patched HTTP/2 client
  • Update transitive golang.org/x/* dependencies pulled in by go mod tidy (crypto, sys, sync, text, tools, etc.)

Affected binaries (same root module):

  • aws-cloud-controller-manager (OCP image via Dockerfile.openshift)
  • ecr-credential-provider

Risk / Impact

  • Runtime risk: Low — exploitation requires a malicious or compromised HTTP/2 server peer; normal AWS/Kubernetes API traffic uses trusted endpoints.
  • Build risk: Vendor-only dependency bump; no application logic changes.

Verification

  • make aws-cloud-controller-manager
  • make ecr-credential-provider
  • go version -m ./aws-cloud-controller-manager reports Go ≥ 1.25.10 (stdlib fix path)
  • govulncheck -mode=binary ./aws-cloud-controller-manager — no GO-2026-4918
  • govulncheck -mode=binary ./ecr-credential-provider — no GO-2026-4918
  • make verify-go-directive
  • make check

Notes

  • The module-path fix is delivered via x/net v0.53.0 in vendor/.
  • The stdlib fix requires building with Go ≥ 1.25.10 (rhel-9-golang-1.25-openshift-4.22 builder patch level should be confirmed for full stdlib coverage).

@openshift-merge-bot

Copy link
Copy Markdown

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 84cfbb64-e5a4-469f-a99d-5b63cf4d5e8b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from damdo and theobarberbany August 20, 2026 11:29
@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 20, 2026
@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown

Hi @atewari-rh. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign elmiko for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant