Skip to content

[release-4.18] OCPBUGS-80219: Fix CVE-2026-33186 using openshift-sustaining grpc-go fork#1041

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
katekeiroz-dev:update-grpc-4.18
Jul 23, 2026
Merged

[release-4.18] OCPBUGS-80219: Fix CVE-2026-33186 using openshift-sustaining grpc-go fork#1041
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.18from
katekeiroz-dev:update-grpc-4.18

Conversation

@katekeiroz-dev

@katekeiroz-dev katekeiroz-dev commented Jun 18, 2026

Copy link
Copy Markdown

Summary

Fix CVE-2026-33186 (gRPC-Go authorization bypass due to improper HTTP/2 path validation) on release-4.18.

Uses the openshift-sustaining/grpc-go v1.71.3-sec.1 fork via a replace directive in go.mod. This fork patches the CVE while remaining compatible with Go 1.22 (the release-4.18 CI toolchain).

Changes

  • Added replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.71.3-sec.1 to go.mod
  • Transitive dependency bumps from MVS (minimal, Go 1.22-compatible)

Why the fork?

Upstream grpc-go v1.79.3 (which fixes the CVE directly) transitively requires Go 1.24+ dependencies (go-jose/go-jose/v4@v4.1.3, cloud.google.com/go/compute/metadata), which are incompatible with the release-4.18 CI builder image (Go 1.22.9/1.22.12).

Related: OCPBUGS-80219

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 18, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-80219, which is invalid:

  • expected dependent Jira Issue OCPBUGS-80400 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Update google.golang.org/grpc to v1.79.3 to address CVE-2026-33186 (gRPC-Go authorization bypass due to improper HTTP/2 path validation).

Related: OCPBUGS-80219

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 18, 2026
@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 7b1131be-54fe-4ab6-bdb7-8bdc5ad74346

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from 2uasimojo and dlom June 18, 2026 20:30
@katekeiroz-dev

Copy link
Copy Markdown
Author

/ok-to-test

@openshift-ci openshift-ci Bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 18, 2026
@katekeiroz-dev katekeiroz-dev changed the title OCPBUGS-80219: Bump google.golang.org/grpc to v1.79.3 [release-4.18] OCPBUGS-80219: Bump google.golang.org/grpc to v1.79.3 Jun 18, 2026
@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest-required

2 similar comments
@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest-required

@katekeiroz-dev

Copy link
Copy Markdown
Author

/retest-required

@dlom

dlom commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jul 8, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@dlom: This pull request references Jira Issue OCPBUGS-80219, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-80400 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-80400 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@dlom

dlom commented Jul 8, 2026

Copy link
Copy Markdown
Contributor

/retest

…fork

Uses openshift-sustaining/grpc-go v1.71.3-sec.1 fork which patches
CVE-2026-33186 (gRPC-Go authorization bypass due to improper HTTP/2
path validation) while remaining compatible with Go 1.22.

Signed-off-by: Kate Barreiros <kbarreir@redhat.com>
@katekeiroz-dev katekeiroz-dev changed the title [release-4.18] OCPBUGS-80219: Bump google.golang.org/grpc to v1.79.3 [release-4.18] OCPBUGS-80219: Fix CVE-2026-33186 using openshift-sustaining grpc-go fork Jul 14, 2026
@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.70%. Comparing base (363e98b) to head (3dc4cfe).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##           release-4.18    #1041   +/-   ##
=============================================
  Coverage         46.70%   46.70%           
=============================================
  Files                97       97           
  Lines             11970    11970           
=============================================
  Hits               5590     5590           
  Misses             5763     5763           
  Partials            617      617           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@katekeiroz-dev

katekeiroz-dev commented Jul 22, 2026

Copy link
Copy Markdown
Author

ci/prow/security failure is pre-existing and unrelated to this PR

Investigated the failing ci/prow/security check. It's the Snyk dependency scan step (not snyk code, which reports 0 issues):

Tested 1264 dependencies for known issues, found 56 issues, 19298 vulnerable paths.
snyk dependencies scan failed

The 56 flagged issues are spread across the Go 1.22.5 standard library (used by the release-4.18 CI builder image) and large third-party dependency trees (AWS/Azure/GCP/IBM SDKs, k8s.io/client-go, controller-runtime, golang.org/x/net/html, etc.). None of them trace back to the grpc-go fork replace directive added here. The repo's .snyk ignore file currently only covers 3 specific findings, well short of the 56 currently detected.

This is a branch-wide, pre-existing issue, not something introduced by this change — ci/prow/security is also currently FAILURE on other open, unrelated PRs targeting release-4.18:

Note that security is not marked optional: true in the Prow job config, so it will block Tide merges on release-4.18 generally until the .snyk ignore list is updated (or deps/toolchain are bumped) at the branch level — this is outside the scope of this targeted CVE backport PR.

/cc maintainers for awareness.
@dlom
@2uasimojo

@2uasimojo

Copy link
Copy Markdown
Member

/override ci/prow/security

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@2uasimojo: Overrode contexts on behalf of 2uasimojo: ci/prow/security

Details

In response to this:

/override ci/prow/security

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

@katekeiroz-dev: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@germanparente

Copy link
Copy Markdown

/label backport-risk-assessed
/verified by ci

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Jul 23, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@germanparente: This PR has been marked as verified by ci.

Details

In response to this:

/label backport-risk-assessed
/verified by ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jul 23, 2026
@katekeiroz-dev

Copy link
Copy Markdown
Author

/jira refresh

@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@katekeiroz-dev: This pull request references Jira Issue OCPBUGS-80219, which is valid.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note type set to "Release Note Not Required"
  • dependent bug Jira Issue OCPBUGS-80400 is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-80400 targets the "4.19.z" version, which is one of the valid target versions: 4.19.0, 4.19.z
  • bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (ocp-sustaining-admins@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@germanparente

Copy link
Copy Markdown

@dlom @2uasimojo

sustaining team can approve PR's only in case of golang module bumps.

/label approved
/lgtm

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-ci openshift-ci Bot added lgtm Indicates that a PR is ready to be merged. and removed approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 23, 2026
@2uasimojo

Copy link
Copy Markdown
Member

/approve

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 2uasimojo, germanparente, katekeiroz-dev

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 23, 2026
@openshift-merge-bot
openshift-merge-bot Bot merged commit f0e7fae into openshift:release-4.18 Jul 23, 2026
12 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@katekeiroz-dev: Jira Issue Verification Checks: Jira Issue OCPBUGS-80219
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-80219 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

Summary

Fix CVE-2026-33186 (gRPC-Go authorization bypass due to improper HTTP/2 path validation) on release-4.18.

Uses the openshift-sustaining/grpc-go v1.71.3-sec.1 fork via a replace directive in go.mod. This fork patches the CVE while remaining compatible with Go 1.22 (the release-4.18 CI toolchain).

Changes

  • Added replace google.golang.org/grpc => github.com/openshift-sustaining/grpc-go v1.71.3-sec.1 to go.mod
  • Transitive dependency bumps from MVS (minimal, Go 1.22-compatible)

Why the fork?

Upstream grpc-go v1.79.3 (which fixes the CVE directly) transitively requires Go 1.24+ dependencies (go-jose/go-jose/v4@v4.1.3, cloud.google.com/go/compute/metadata), which are incompatible with the release-4.18 CI builder image (Go 1.22.9/1.22.12).

Related: OCPBUGS-80219

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.18.0-0.nightly-2026-07-23-212204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants