Skip to content

CM-1042: To add multi-operand qualification suite in e2e tests #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arun717 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

CM-1042: To add multi-operand qualification suite in e2e tests #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
28e010f
test(e2e): add multi-operand qualification suite
arun717 Jun 19, 2026
3a05373
test(e2e): address multi-operand PR review feedback
arun717 Jul 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 11 additions & 7 deletions test/e2e/issuer_acme_http01_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,16 @@ var _ = Describe("ACME Issuer HTTP01 solver", Label("Platform:Generic"), Ordered

It("should obtain a valid certificate", func() {

By("waiting for certificate to become ready")
err := waitForCertificateReadiness(ctx, secretName, ns.Name)
Expect(err).NotTo(HaveOccurred(), "timeout waiting for certificate to become ready")

By("checking TLS certificate contents")
err := wait.PollUntilContextTimeout(ctx, slowPollInterval, highTimeout, true, func(context.Context) (bool, error) {
err = verifyCertificate(ctx, secretName, ns.Name, ingressHost)
Expect(err).NotTo(HaveOccurred(), "certificate verification failed")

By("verifying live Ingress TLS endpoint")
err = wait.PollUntilContextTimeout(ctx, slowPollInterval, highTimeout, true, func(context.Context) (bool, error) {
secret, err := loader.KubeClient.CoreV1().Secrets(ns.Name).Get(ctx, secretName, metav1.GetOptions{})
if err != nil {
return false, nil // keep polling until the Secret exists
Expand All @@ -246,7 +254,7 @@ var _ = Describe("ACME Issuer HTTP01 solver", Label("Platform:Generic"), Ordered

return isHostCorrect && isNotExpired, nil
})
Expect(err).NotTo(HaveOccurred(), "timeout waiting for valid TLS certificate")
Expect(err).NotTo(HaveOccurred(), "timeout waiting for valid live Ingress TLS certificate")
})

It("should create solver pods with custom resource limits and requests", func() {
Expand All @@ -265,7 +273,7 @@ var _ = Describe("ACME Issuer HTTP01 solver", Label("Platform:Generic"), Ordered
}

err := wait.PollUntilContextTimeout(ctx, fastPollInterval, lowTimeout, true, func(ctx context.Context) (bool, error) {
pods, err := k8sClientSet.CoreV1().Pods("").List(ctx, metav1.ListOptions{
pods, err := k8sClientSet.CoreV1().Pods(ns.Name).List(ctx, metav1.ListOptions{
LabelSelector: acmeSolverPodLabel,
})
if err != nil {
Expand All @@ -286,10 +294,6 @@ var _ = Describe("ACME Issuer HTTP01 solver", Label("Platform:Generic"), Ordered
return false, nil // No matching pods yet, keep waiting
})
Expect(err).NotTo(HaveOccurred(), "should find ACME HTTP01 solver pods with expected resource configuration")

By("waiting for certificate to get ready")
Comment thread
arun717 marked this conversation as resolved.
err = waitForCertificateReadiness(ctx, secretName, ns.Name)
Expect(err).NotTo(HaveOccurred(), "timeout waiting for certificate to become ready")
})
})

Expand Down
Loading