Skip to content

chore: use GOPATH for scan in Makefile#950

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
feichashao:make-coverage
Jun 5, 2026
Merged

chore: use GOPATH for scan in Makefile#950
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
feichashao:make-coverage

Conversation

@feichashao
Copy link
Copy Markdown
Contributor

@feichashao feichashao commented Jun 5, 2026

What type of PR is this?

  • fix (Bug Fix)
  • feat (New Feature)
  • docs (Documentation)
  • test (Test Coverage)
  • chore (Clean Up / Maintenance Tasks)
  • other (Anything that doesn't fit the above)

What this PR does / Why we need it?

The ensure-govulncheck checks $(GOPATH)/bin/govulncheck while the scan runs the govulncheck in the default path. This could lead to inconsistent if the GOPATH/bin is not in the PATH.

This PR makes scan to execute $(GOPATH)/bin/govulncheck explicitly.

Which Jira/Github issue(s) does this PR fix?

  • Related Issue #
  • Closes #

Special notes for your reviewer

Unit Test Coverage

Guidelines

  • If it's a new sub-command or new function to an existing sub-command, please cover at least 50% of the code
  • If it's a bug fix for an existing sub-command, please cover 70% of the code

Test coverage checks

  • Added unit tests
  • Created jira card to add unit test
  • This PR may not need unit tests

Pre-checks (if applicable)

  • Ran unit tests locally
  • Validated the changes in a cluster
  • Included documentation changes with PR
  • Backward compatible

/label tide/merge-method-squash

Summary by CodeRabbit

  • Chores
    • Updated build scan process to use an explicit tool path for improved reliability and consistency.

@openshift-ci openshift-ci Bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 5, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 5, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: ec909fc0-081d-4fd4-8170-9db94b014eba

📥 Commits

Reviewing files that changed from the base of the PR and between 0ab5769 and fd687a9.

📒 Files selected for processing (1)
  • Makefile

Walkthrough

The Makefile scan target now uses an explicit path to the installed govulncheck binary at $(GOPATH)/bin/govulncheck instead of invoking it from the system PATH. All other logic including output capture and vulnerability detection remains unchanged.

Changes

Build Tool Configuration

Layer / File(s) Summary
Scan target govulncheck path
Makefile
The scan target now invokes $(GOPATH)/bin/govulncheck instead of govulncheck, ensuring the build uses the explicitly installed tool version.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Suggested labels

lgtm, approved

Suggested reviewers

  • Tafhim
  • xiaoyu74
  • MitaliBhalla
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore: use GOPATH for scan in Makefile' accurately describes the main change: updating the scan target to use the explicit GOPATH location for govulncheck.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from diakovnec and smarthall June 5, 2026 07:17
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

@feichashao: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.99%. Comparing base (0ab5769) to head (fd687a9).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   54.02%   53.99%   -0.04%     
==========================================
  Files          82       82              
  Lines        6323     6323              
==========================================
- Hits         3416     3414       -2     
- Misses       2462     2463       +1     
- Partials      445      446       +1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@xiaoyu74
Copy link
Copy Markdown
Contributor

xiaoyu74 commented Jun 5, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: feichashao, xiaoyu74

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [feichashao,xiaoyu74]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit 131fb3e into openshift:main Jun 5, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants