WIP: Remove feature gate VolumeGroupSnapshot

[jsafrane]

Summary

Removes the VolumeGroupSnapshot feature gate, which is no longer needed.

• Removed the FeatureGateVolumeGroupSnapshot definition from features/features.go
• Regenerated features.md and the payload feature gate manifests via make update

The feature gate did not gate any API fields (no +openshift:enable:FeatureGate=VolumeGroupSnapshot annotations existed), so no type definitions or CRDs required changes.

/hold for openshift/cluster-csi-snapshot-controller-operator#297

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

Hello @jsafrane! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8339df40-926a-4125-9183-d39e1413fdf3

📥 Commits

Reviewing files that changed from the base of the PR and between 8127870 and c7c8299.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

💤 Files with no reviewable changes (10)

• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• features.md
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.

---

📝 Walkthrough

Walkthrough

The change removes the FeatureGateVolumeGroupSnapshot registration and its feature support matrix row. It also removes VolumeGroupSnapshot from enabled or disabled feature lists in HyperShift and self-managed HA manifests for default, preview, OKD, and tech-preview configurations.

Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to c7c82

The change removes the promoted VolumeGroupSnapshot feature gate and its generated manifest and documentation entries. No current merge-readiness risk is identified.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	PASS. The pull request changes only the feature matrix, feature-gate registration, and YAML manifests. The parent-to-HEAD diff contains no Ginkgo test files, test-title calls, or dynamic test values. …
Test Structure And Quality	✅ Passed	PASS: The pull request changes only feature metadata, feature-gate registration, and generated YAML manifests. The exact diff contains no Ginkgo test files or test blocks. Therefore, the stated requir…
Microshift Test Compatibility	✅ Passed	The check is not applicable. The pull request changes only feature metadata, Go feature-gate registration, and YAML manifests. The diff contains no added Ginkgo tests or test files, so it introduces n…
Single Node Openshift (Sno) Test Compatibility	✅ Passed	PASS. The pull request adds no Ginkgo tests or test files. The verified patch contains only deletions from features.md, features/features.go, and feature-gate YAML manifests. Therefore, the SNO mu…
Topology-Aware Scheduling Compatibility	✅ Passed	PASS. The pull request changes only features.md, the feature-gate registration, and eight feature-gate payload manifests. The diff only removes VolumeGroupSnapshot entries. It adds or modifies no …
Ote Binary Stdout Contract	✅ Passed	The PR changes one feature-gate declaration, documentation, and YAML manifests. The introduced lines contain no stdout writes, logging configuration, suite setup, or process entry-point code. Therefor…
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	PASS. The pull request changes only feature metadata, the feature declaration, and generated feature-gate manifests. The HEAD-versus-parent diff contains 10 modified files and 33 deletions, with no ad…
No-Weak-Crypto	✅ Passed	PASS. The pull request changes only delete the VolumeGroupSnapshot feature-gate definition, documentation row, and manifest entries. The exact diff has no added lines. It introduces no MD5, SHA1, DE…
Container-Privileges	✅ Passed	PASS. The PR diff against origin/master contains only deletions: one feature-table row, one Go feature-gate definition, and feature-gate manifest entries. No added lines contain privileged, hostPID, h…
No-Sensitive-Data-In-Logs	✅ Passed	PASS. The commit contains only deletions: one feature definition, one documentation row, and feature-gate manifest entries. It adds no logging code, sensitive-data literals, or other content that coul…
Title check	✅ Passed	The title clearly identifies the main change: removing the VolumeGroupSnapshot feature gate.
Description check	✅ Passed	The description accurately explains the feature gate removal and the regeneration of related documentation and manifests.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment