Skip to content

OBSINTA-1609: cluster-troubleshoot skill rename tools to scripts - #46

Open
tremes wants to merge 1 commit into
openshift:mainfrom
tremes:cluster-troubleshoot
Open

OBSINTA-1609: cluster-troubleshoot skill rename tools to scripts#46
tremes wants to merge 1 commit into
openshift:mainfrom
tremes:cluster-troubleshoot

Conversation

@tremes

@tremes tremes commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

The agent assumed tools/ was relative to the working directory (/app), but the scripts are mounted inside the skill directory. This caused nondeterministic code 127 failures during analysis. Add explicit guidance to resolve tool paths relative to the SKILL.md location.

Assisted-by: Claude Code:claude-opus-4-6

@openshift-ci
openshift-ci Bot requested review from falox and iNecas August 12, 2026 08:35
@openshift-ci

openshift-ci Bot commented Aug 12, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tremes

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2026
@rioloc

rioloc commented Aug 12, 2026

Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2026
@tremes tremes changed the title fix: add tool path resolution hint to SKILL.md NO-JIRA: add tool path resolution hint to SKILL.md Aug 12, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tremes: This pull request explicitly references no jira issue.

Details

In response to this:

The agent assumed tools/ was relative to the working directory (/app), but the scripts are mounted inside the skill directory. This caused nondeterministic code 127 failures during analysis. Add explicit guidance to resolve tool paths relative to the SKILL.md location.

Assisted-by: Claude Code:claude-opus-4-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tremes

tremes commented Aug 12, 2026

Copy link
Copy Markdown
Contributor Author

/verified by @tremes manually

@openshift-ci-robot

Copy link
Copy Markdown

@tremes: This PR has been marked as verified by @tremes manually.

Details

In response to this:

/verified by @tremes manually

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Aug 12, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 3942974 and 2 for PR HEAD bbdcbf1 in total

@tremes tremes changed the title NO-JIRA: add tool path resolution hint to SKILL.md OBSINTA-1609: add tool path resolution hint to SKILL.md Aug 12, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 12, 2026

Copy link
Copy Markdown

@tremes: This pull request references OBSINTA-1609 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.0.0" version, but no target version was set.

Details

In response to this:

The agent assumed tools/ was relative to the working directory (/app), but the scripts are mounted inside the skill directory. This caused nondeterministic code 127 failures during analysis. Add explicit guidance to resolve tool paths relative to the SKILL.md location.

Assisted-by: Claude Code:claude-opus-4-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tremes

tremes commented Aug 13, 2026

Copy link
Copy Markdown
Contributor Author

/override ci/prow/eval

@openshift-ci

openshift-ci Bot commented Aug 13, 2026

Copy link
Copy Markdown

@tremes: tremes unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers openshift-sustaining-engineers.

Details

In response to this:

/override ci/prow/eval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.


# Tools

A `tools/` directory is colocated with this SKILL.md file. **Do not assume `tools/` is relative to the working directory.** Use the absolute path based on where you read this file from — for example, if you read this file from `/app/skills/investigate-alert/SKILL.md`, the tools are at `/app/skills/investigate-alert/tools/`.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You wouldn't need this at all if you adhered to the Agent Skills spec and used scripts/ instead. Models will find it more familiar.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am also curious if there's any evidence these tools are useful, the latest models understand how to debug a kubernetes cluster without this information. Perhaps it is helpful to smaller models.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I didn't know about this. I am going to update.

I think it's still useful since there's no MCP or skill as far as I know defining the communication with Prometheus & Alertmanager.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD b199bef and 1 for PR HEAD bbdcbf1 in total

Signed-off-by: Tomáš Remeš <tremes@redhat.com>
@tremes
tremes force-pushed the cluster-troubleshoot branch from bbdcbf1 to cf0e842 Compare August 17, 2026 09:52
@openshift-ci-robot openshift-ci-robot removed the verified Signifies that the PR passed pre-merge verification criteria label Aug 17, 2026
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2026
@tremes tremes changed the title OBSINTA-1609: add tool path resolution hint to SKILL.md NO-JIRA: cluster-troubleshoot skill rename tools to scripts Aug 17, 2026
@openshift-ci-robot

Copy link
Copy Markdown

@tremes: This pull request explicitly references no jira issue.

Details

In response to this:

The agent assumed tools/ was relative to the working directory (/app), but the scripts are mounted inside the skill directory. This caused nondeterministic code 127 failures during analysis. Add explicit guidance to resolve tool paths relative to the SKILL.md location.

Assisted-by: Claude Code:claude-opus-4-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tremes tremes changed the title NO-JIRA: cluster-troubleshoot skill rename tools to scripts OBSINTA-1609: cluster-troubleshoot skill rename tools to scripts Aug 17, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 17, 2026

Copy link
Copy Markdown

@tremes: This pull request references OBSINTA-1609 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "5.1.0" version, but no target version was set.

Details

In response to this:

The agent assumed tools/ was relative to the working directory (/app), but the scripts are mounted inside the skill directory. This caused nondeterministic code 127 failures during analysis. Add explicit guidance to resolve tool paths relative to the SKILL.md location.

Assisted-by: Claude Code:claude-opus-4-6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@falox

falox commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 19, 2026
@Cali0707

Copy link
Copy Markdown
Contributor

/override ci/prow/eval

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

@Cali0707: Overrode contexts on behalf of Cali0707: ci/prow/eval

Details

In response to this:

/override ci/prow/eval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown

@tremes: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants