feat: add SBR detection-mode and NHC+FAR default configs by geetikakay · Pull Request #276 · openshift-virtualization/virt-platform-autopilot

geetikakay · 2026-07-30T07:43:55Z

Add StorageBasedRemediationConfig asset with detectOnlyMode: Enabled
Add NodeHealthCheck asset with FAR as remediator
Add storageProfileRWXClass template function to auto-detect RWX Filesystem StorageClass from CDI StorageProfiles
Add RBAC for cdi.kubevirt.io/storageprofiles and storage-based-remediation.medik8s.io/storagebasedremediationconfigs
Add unit tests for storageProfileRWXClass (single/multiple/none/nil)

Admin can override storage class via platform.kubevirt.io/sbr-storage-class annotation on HCO. User must create fenceagentsremediationtemplate-default in openshift-workload-availability with BMC credentials.

Plan to add e2e in next PR

openshift-ci · 2026-07-30T07:44:06Z

Hi @geetikakay. Thanks for your PR.

I'm waiting for a openshift-virtualization member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

geetikakay · 2026-07-30T07:45:47Z

@ksimon1 @jcanocan could you please check

jcanocan · 2026-07-30T09:58:33Z

@ksimon1 @jcanocan could you please check

Looks good to me, nice job!

ksimon1 · 2026-07-31T06:10:04Z

+
+		var candidates []string
+		for _, profile := range profiles.Items {
+			sets, found, _ := unstructured.NestedSlice(profile.Object, "status", "claimPropertySets")


You should not be ignoring errors returned by unstructured functions

I didn't opt to add error checks because it's purely downstream work and both volumeMode and accessModes are schema-required fields within claimPropertySets (enforced by CDI). They cannot be absent in data returned by the API server.

just logging at debug level as a troubleshooting hint for corner cases?

added. I use cause since it is optional so raising error might not be appropriate.

tiraboschi · 2026-07-31T13:59:47Z

/ok-to-test

tiraboschi · 2026-07-31T14:13:09Z

+  # Admin should set platform.kubevirt.io/sbr-storage-class on HCO if multiple RWX classes exist.
+  - name: sbr-detection-config
+    path: active/node-remediation/storage-based-remediation-config.yaml.tpl
+    phase: 1
+    install: always


are we going to mark this "feature" it as GA as merged or do we prefer to gate it with an opt-in annotation on HCO? see also: #271

I did couple of changes(added opt-in). maturity, asserts and requires i could add once 271 is merge

ksimon1 · 2026-08-03T14:01:32Z

/lgtm

openshift-ci · 2026-08-03T14:01:34Z

@ksimon1: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

geetikakay · 2026-08-04T06:55:16Z

cc @rlobillo

github-actions · 2026-08-04T10:05:09Z

❌ Generated Files Verification Failed

One or more generated files in this PR are out of sync:

CRDs: Run make update-crds if CRD verification failed
RBAC: Run make generate-rbac if RBAC verification failed

Please regenerate the files locally and commit the changes.

tiraboschi · 2026-08-04T10:06:49Z

@geetikakay in hack/update-crds.sh we also have a script to keep CRDs used in test environment (like test/crds/remediation/storagebasedremediationconfigs.storage-based-remediation.medik8s.io.yaml ) up to date with their upstream counterpart. Could you please add an entry there for storagebasedremediationconfigs one?

- Add StorageBasedRemediationConfig asset with detectOnlyMode: Enabled - Add NodeHealthCheck asset with FAR as remediator - Add storageProfileRWXClass template function to auto-detect RWX Filesystem StorageClass from CDI StorageProfiles - Add RBAC for cdi.kubevirt.io/storageprofiles and storage-based-remediation.medik8s.io/storagebasedremediationconfigs - Add unit tests for storageProfileRWXClass (single/multiple/none/nil) Admin can override storage class via platform.kubevirt.io/sbr-storage-class annotation on HCO. User must create fenceagentsremediationtemplate-default in openshift-workload-availability with BMC credentials. Signed-off-by: Geetika Kapoor <gkapoor@redhat.com> Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>

tiraboschi · 2026-08-04T13:40:50Z

/lgtm

tiraboschi · 2026-08-04T13:40:55Z

/approve

openshift-ci · 2026-08-04T13:41:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [tiraboschi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

razo7 · 2026-08-12T07:11:57Z

 	case "fence-agents-remediation.medik8s.io":
 		return "Fence Agents Remediation"
+	case "storage-based-remediation.medik8s.io":
+		return "Storage Based Remediation"


The official name has a hyphen

Suggested change

return "Storage Based Remediation"

return "Storage-Based Remediation"

@razo7 ack. #301

openshift-ci Bot added do-not-merge/work-in-progress needs-ok-to-test labels Jul 30, 2026

geetikakay marked this pull request as ready for review July 30, 2026 13:40

openshift-ci Bot removed the do-not-merge/work-in-progress label Jul 30, 2026

ksimon1 reviewed Jul 31, 2026

View reviewed changes

Comment thread pkg/engine/renderer.go

ksimon1 reviewed Jul 31, 2026

View reviewed changes

Comment thread pkg/engine/renderer.go Outdated

ksimon1 reviewed Jul 31, 2026

View reviewed changes

Comment thread pkg/engine/renderer.go Outdated

ksimon1 reviewed Jul 31, 2026

View reviewed changes

geetikakay force-pushed the add_node_remediation_config branch from dba76b2 to 62edc11 Compare July 31, 2026 11:27

openshift-ci Bot added ok-to-test and removed needs-ok-to-test labels Jul 31, 2026

tiraboschi reviewed Jul 31, 2026

View reviewed changes

geetikakay force-pushed the add_node_remediation_config branch 2 times, most recently from 1cb7453 to 0d2f2f1 Compare August 3, 2026 09:00

ksimon1 reviewed Aug 3, 2026

View reviewed changes

Comment thread pkg/engine/renderer.go

ksimon1 reviewed Aug 3, 2026

View reviewed changes

Comment thread assets/active/node-remediation/nhc-far.yaml Outdated

ksimon1 reviewed Aug 3, 2026

View reviewed changes

Comment thread assets/active/node-remediation/nhc-far.yaml Outdated

geetikakay force-pushed the add_node_remediation_config branch from 0d2f2f1 to 9278df5 Compare August 3, 2026 12:53

geetikakay requested a review from tiraboschi August 4, 2026 03:15

geetikakay force-pushed the add_node_remediation_config branch from 9278df5 to 397077e Compare August 4, 2026 10:31

openshift-ci Bot assigned tiraboschi Aug 4, 2026

openshift-ci Bot added the lgtm label Aug 4, 2026

openshift-ci Bot added the approved label Aug 4, 2026

openshift-merge-bot Bot merged commit 68df086 into openshift-virtualization:main Aug 4, 2026
7 checks passed

razo7 reviewed Aug 12, 2026

View reviewed changes

	return "Storage Based Remediation"
	return "Storage-Based Remediation"

Uh oh!

Conversation

geetikakay commented Jul 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci Bot commented Jul 30, 2026

Uh oh!

geetikakay commented Jul 30, 2026

Uh oh!

jcanocan commented Jul 30, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksimon1 Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

geetikakay Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

tiraboschi Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

geetikakay Aug 3, 2026

Choose a reason for hiding this comment

Uh oh!

tiraboschi commented Jul 31, 2026

Uh oh!

tiraboschi Jul 31, 2026

Choose a reason for hiding this comment

Uh oh!

geetikakay Aug 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ksimon1 commented Aug 3, 2026

Uh oh!

openshift-ci Bot commented Aug 3, 2026

Uh oh!

geetikakay commented Aug 4, 2026

Uh oh!

github-actions Bot commented Aug 4, 2026

Uh oh!

tiraboschi commented Aug 4, 2026

Uh oh!

tiraboschi commented Aug 4, 2026

Uh oh!

tiraboschi commented Aug 4, 2026

Uh oh!

openshift-ci Bot commented Aug 4, 2026

Uh oh!

Uh oh!

razo7 Aug 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

geetikakay Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

geetikakay commented Jul 30, 2026 •

edited

Loading

geetikakay Aug 3, 2026 •

edited

Loading

razo7 Aug 12, 2026 •

edited

Loading