Skip to content

fix: cast mvindex index arithmetic to INTEGER type for Calcite ITEM compatibility (#5660) #5670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
waterWang wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

fix: cast mvindex index arithmetic to INTEGER type for Calcite ITEM compatibility (#5660) #5670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions ...rc/main/java/org/opensearch/sql/expression/function/CollectionUDF/MVIndexFunctionImp.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
import org.apache.calcite.rex.RexBuilder;
import org.apache.calcite.rex.RexNode;
import org.apache.calcite.sql.fun.SqlStdOperatorTable;
import org.apache.calcite.sql.type.SqlTypeName;
import org.opensearch.sql.expression.function.PPLFuncImpTable;

/**
Expand Down Expand Up @@ -64,12 +65,16 @@ public RexNode resolve(RexBuilder builder, RexNode... args) {

/** Non-widening integer addition for internal, int-domain array-index math. */
private static RexNode add(RexBuilder builder, RexNode left, RexNode right) {
return builder.makeCall(SqlStdOperatorTable.PLUS, left, right);
RexNode result = builder.makeCall(SqlStdOperatorTable.PLUS, left, right);
return builder.makeCast(
builder.getTypeFactory().createSqlType(SqlTypeName.INTEGER), result);
}

/** Non-widening integer subtraction for internal, int-domain array-index math. */
private static RexNode subtract(RexBuilder builder, RexNode left, RexNode right) {
return builder.makeCall(SqlStdOperatorTable.MINUS, left, right);
RexNode result = builder.makeCall(SqlStdOperatorTable.MINUS, left, right);
return builder.makeCast(
builder.getTypeFactory().createSqlType(SqlTypeName.INTEGER), result);
}

/**
Expand Down