Decode URL-encoded user and password when parsing host credentials - #341
Open
magic-peach wants to merge 1 commit into
Open
magic-peach wants to merge 1 commit into
magic-peach wants to merge 1 commit into
Conversation
Signed-off-by: Akanksha Trehun <akankshatrehun@gmail.com>
magic-peach
requested review from
VachaShah,
VijayanB,
harshavamsi,
nhtruong,
robsears and
vamshin
as code owners
September 20, 2026 17:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Client#__parse_host extracts user and password from a host URL using URI::Generic and URI, but Ruby's URI#user and URI#password return the still percent-encoded values. Client#perform_request later calls CGI.escape on those same values when building the request URL, so a password containing reserved characters gets double encoded and the wrong password is sent to the server.
This decodes the user and password with CGI.unescape right after extracting them in Client#__parse_host, for both the String and URI branches, so the values stored on the client are the actual credentials rather than their encoded form.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here: https://github.com/opensearch-project/OpenSearch/blob/main/CONTRIBUTING.md#developer-certificate-of-origin