docs: add Unified Alerts View and SLOs pages under Alerting - #388
Merged
anirudha merged 2 commits intoAug 5, 2026
Merged
Conversation
lezzago
requested review from
anirudha,
goyamegh,
joshuali925,
kylehounslow,
ps48 and
vamsimanohar
as code owners
August 4, 2026 23:40
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage 55.62% 55.62%
=======================================
Files 4 4
Lines 169 169
Branches 47 47
=======================================
Hits 94 94
Misses 74 74
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Add a Unified Alerts View page and a three-page SLOs section (overview, create, explore) to the Alerting section, with walkthrough GIFs and screenshots. Move the Alerting group to sit after Send Data in the sidebar. Keep the pages generic (feature-style), consistent with the other feature docs. Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
force-pushed
the
docs/alerting-slo-unified-alerts
branch
from
August 4, 2026 23:45
959570a to
2c5d595
Compare
lezzago
marked this pull request as draft
August 4, 2026 23:52
The company-name generator sanitized `< > " ' &` out of the fast-check string but had no fallback, so a short input made entirely of those characters collapsed to an empty string and failed the `alt` truthiness assertion (seed-dependent flake). Add the `|| 'company name'` fallback, matching the pattern already used by the other alt-text generators in this file. Signed-off-by: Ashish Agrawal <ashisagr@amazon.com>
lezzago
marked this pull request as ready for review
August 5, 2026 00:07
anirudha
approved these changes
Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds documentation for two alerting/monitoring features and reorganizes the Alerting section of the docs site.
Style
The pages are written generically in the feature-documentation style used by the other feature pages (anomaly-detection, apm, investigate) — concept + UI walkthrough, without deployment-specific plumbing (container names, compose files, ports, curl commands, repo paths).
Testing
npm run buildpasses with clean internal-link validation (141 pages). Verified all pages render and images load via the local preview.Misc
Also includes a small unrelated fix for a flaky property-based test in
Performance.test.ts(a sanitized fast-check company name could collapse to an empty string and fail analttruthiness assertion). Added a fallback matching the existing pattern in that file.