Fix failing tests - #2203
Open
vikhy-aws wants to merge 2 commits into
Open
Conversation
…nt check The prepareMonitorIndexing() method searches SCHEDULED_JOBS_INDEX to validate the monitor count limit. When a preceding test wipes all indices, this search can fail with SearchPhaseExecutionException (all shards failed) or IndexNotFoundException if the index hasn't been recreated yet. Handle these cases gracefully by proceeding to index the monitor, since an unavailable index implies zero existing monitors. Resolves opensearch-project#2199 Signed-off-by: Vikhyat Khare <kvikhy@amazon.com> Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
Signed-off-by: vikhy-aws <191836418+vikhy-aws@users.noreply.github.com>
vikhy-aws
requested review from
AWSHurneyt,
KashKondaka,
amsiglan,
bowenlan-amzn,
eirsep,
engechas,
getsaurabh02,
goyamegh,
lezzago,
manaswini1920,
nishtham-amazon,
rishabhmaurya,
riysaxen-amzn and
toepkerd
as code owners
July 30, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The prepareMonitorIndexing() method searches SCHEDULED_JOBS_INDEX to
validate the monitor count limit. When a preceding test wipes all indices,
this search can fail with SearchPhaseExecutionException (all shards failed)
or IndexNotFoundException if the index hasn't been recreated yet.
Handle these cases gracefully by proceeding to index the monitor, since
an unavailable index implies zero existing monitors.
Related Issues
Resolves #2199
Check List
--signoff.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.