Fix monitor mode workload group rejections - #22654
Open
SaiManas2106 wants to merge 1 commit into
Open
Conversation
Signed-off-by: SaiManas2106 <saimanas2004@gmail.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
|
❌ Gradle check result for 7d363ac: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Author
|
The Gradle check failure appears unrelated to this PR. Failed test: Failure: This test has an existing flaky-test report: #17692. This PR only changes WLM monitor-mode rejection handling and its WLM regression test; it does not modify HDFS repository code. Could the Gradle check please be rerun? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Monitor-mode workload groups are intended to observe resource usage without
rejecting live traffic. However,
rejectIfNeededstill threwOpenSearchRejectedExecutionExceptionwhen a monitor group exceeded aresource limit.
This change skips rejection for
MONITORmode while preserving the existingbehavior for
SOFTandENFORCEDmodes. It adds a regression test for anover-limit monitor group while the node is under duress, asserting that no
rejection counters are incremented.
Related Issues
Resolves #22616
Check List
Testing
./gradlew :server:test --tests "org.opensearch.wlm.WorkloadGroupServiceTests"./gradlew :server:spotlessJavaCheckBy submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.