Pin pre-commit hooks#1114
Open
StevenMaude wants to merge 1 commit into
Open
Conversation
And remove the hadolint hook. It was from: stratasan/hadolint-pre-commit@cdefcb0 which was simply: ``` - id: hadolint name: Hadolint description: Haskell-based Docker image linter language: docker_image types: - dockerfile entry: --entrypoint /bin/hadolint hadolint/hadolint:latest --ignore DL3013 --ignore DL3018 --ignore DL3008 - ``` This is a local version of the same hook, but without the ignores. The ignores weren't needed, so we should remove them. (And we should really ignore rules in the Dockerfile as we do already.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
And remove the hadolint hook.
It was from:
stratasan/hadolint-pre-commit@cdefcb0
which was simply:
This is a local version of the same hook, but without the ignores. The ignores weren't needed, so we should remove them. (And we should really ignore rules in the Dockerfile as we do already.)